From af611d4bcbff60413e61160cfc16c8d49e2d833c Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 25 Apr 2024 17:26:12 +0530 Subject: [PATCH] fix(report_utils): ensure that delimiter and separator can't be empty This results in them setting as `undefined`, which ends up as a string in python, and the delimiter ends up as `'u'`, and the separator as `'undefined'`. Signed-off-by: Akhil Narang --- .../public/js/frappe/views/reports/report_utils.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/views/reports/report_utils.js b/frappe/public/js/frappe/views/reports/report_utils.js index 534622bfff..485d233846 100644 --- a/frappe/public/js/frappe/views/reports/report_utils.js +++ b/frappe/public/js/frappe/views/reports/report_utils.js @@ -264,8 +264,18 @@ frappe.report_utils = { dialog.fields_dict["file_format"].df.onchange = () => update_csv_preview(dialog); dialog.fields_dict["csv_quoting"].df.onchange = () => update_csv_preview(dialog); - dialog.fields_dict["csv_delimiter"].df.onchange = () => update_csv_preview(dialog); - dialog.fields_dict["csv_decimal_sep"].df.onchange = () => update_csv_preview(dialog); + dialog.fields_dict["csv_delimiter"].df.onchange = () => { + if (!dialog.get_value("csv_delimiter")) { + dialog.set_value("csv_delimiter", ","); + } + update_csv_preview(dialog); + }; + dialog.fields_dict["csv_decimal_sep"].df.onchange = () => { + if (!dialog.get_value("csv_decimal_sep")) { + dialog.set_value("csv_decimal_sep", "."); + } + update_csv_preview(dialog); + }; return dialog; },