From af7dc6b774846fcf4e473854b37104a4efa75f6e Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 15 Feb 2022 20:24:03 +0530 Subject: [PATCH] fix: after load more on refresh gets duplicate data --- frappe/public/js/frappe/list/base_list.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js index ed27bdb29e..d09a1c7043 100644 --- a/frappe/public/js/frappe/list/base_list.js +++ b/frappe/public/js/frappe/list/base_list.js @@ -391,9 +391,10 @@ frappe.views.BaseList = class BaseList { $this.addClass("btn-info"); this.start = 0; - this.page_length = $this.data().value; + this.page_length = this.selected_page_count = $this.data().value; } else if ($this.is(".btn-more")) { this.start = this.start + this.page_length; + this.page_length = this.selected_page_count || 20; } this.refresh(); }); @@ -474,6 +475,7 @@ frappe.views.BaseList = class BaseList { this.render(); this.after_render(); this.freeze(false); + this.reset_defaults(); if (this.settings.refresh) { this.settings.refresh(this); } @@ -500,6 +502,11 @@ frappe.views.BaseList = class BaseList { this.data = this.data.uniqBy((d) => d.name); } + reset_defaults() { + this.page_length = this.page_length + this.start; + this.start = 0; + } + freeze() { // show a freeze message while data is loading }