vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

perf: manually cast doc.name to string (#32292)

Browse source 
This avoid full table scans and undesired implicit casting at MySQL level.
This commit is contained in:
Ankush Menat 2025-04-25 10:51:08 +05:30 • committed by GitHub
parent d998d520fb
commit afc19dec10
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/desk/form/document_follow.py
View file

@ -235,7 +235,7 @@ def get_comments(doctype, doc_name, frequency, user):
def is_document_followed(doctype, doc_name, user):
return frappe.db.exists(
"Document Follow", {"ref_doctype": doctype, "ref_docname": doc_name, "user": user}
"Document Follow", {"ref_doctype": doctype, "ref_docname": str(doc_name), "user": user}
)

12
frappe/desk/form/load.py
View file

@ -177,7 +177,7 @@ def get_milestones(doctype, name):
return frappe.get_all(
"Milestone",
fields=["creation", "owner", "track_field", "value"],
filters=dict(reference_type=doctype, reference_name=name),
filters=dict(reference_type=doctype, reference_name=str(name)),
)
@ -185,7 +185,7 @@ def get_attachments(dt, dn):
return frappe.get_all(
"File",
fields=["name", "file_name", "file_url", "is_private"],
filters={"attached_to_name": dn, "attached_to_doctype": dt},
filters={"attached_to_name": str(dn), "attached_to_doctype": dt},
)
@ -333,7 +333,7 @@ def get_communication_data(
},
dict(
doctype=doctype,
name=name,
name=str(name),
start=frappe.utils.cint(start),
limit=limit,
),
@ -347,7 +347,7 @@ def get_assignments(dt, dn):
fields=["name", "allocated_to as owner", "description", "status"],
filters={
"reference_type": dt,
"reference_name": dn,
"reference_name": str(dn),
"status": ("not in", ("Cancelled", "Closed")),
"allocated_to": ("is", "set"),
},
@ -368,7 +368,7 @@ def get_view_logs(doc: "Document") -> list[dict]:
"View Log",
filters={
"reference_doctype": doc.doctype,
"reference_name": doc.name,
"reference_name": str(doc.name),
},
fields=["name", "creation", "owner"],
order_by="creation desc",
@ -383,7 +383,7 @@ def get_tags(doctype: str, name: str) -> str:
tags = frappe.get_all(
"Tag Link",
filters={"document_type": doctype, "document_name": name},
filters={"document_type": doctype, "document_name": str(name)},
fields=["tag"],
pluck="tag",
)

2
frappe/share.py
View file

@ -148,7 +148,7 @@ def _get_users(doc: "Document") -> list:
"owner",
"creation",
],
filters=dict(share_doctype=doc.doctype, share_name=doc.name),
filters=dict(share_doctype=doc.doctype, share_name=str(doc.name)),
)