From 313605d328d192078b41fd196b41af21754373cf Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankush@frappe.io>
Date: Sat, 5 Nov 2022 20:37:43 +0530
Subject: [PATCH 1/2] fix: standard dashboards not loading

---
 frappe/public/js/frappe/views/breadcrumbs.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js
index 5236c21ac2..53a3300a94 100644
--- a/frappe/public/js/frappe/views/breadcrumbs.js
+++ b/frappe/public/js/frappe/views/breadcrumbs.js
@@ -137,13 +137,13 @@ frappe.breadcrumbs = {
 		const doctype_meta = frappe.get_doc("DocType", doctype);
 		if (
 			(doctype === "User" && !frappe.user.has_role("System Manager")) ||
-			(doctype_meta && doctype_meta.issingle)
+			doctype_meta?.issingle
 		) {
 			// no user listview for non-system managers and single doctypes
 		} else {
 			let route;
 			const doctype_route = frappe.router.slug(frappe.router.doctype_layout || doctype);
-			if (doctype_meta.is_tree) {
+			if (doctype_meta?.is_tree) {
 				let view = frappe.model.user_settings[doctype].last_view || "Tree";
 				route = `${doctype_route}/view/${view}`;
 			} else {

From 5d1d3564ef41ceec652c7f097ae9ef4150420ffa Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankush@frappe.io>
Date: Sat, 5 Nov 2022 20:45:02 +0530
Subject: [PATCH 2/2] test: Dashboard basic ui test + whitelisting

---
 cypress/integration/dashboard.js | 50 ++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 cypress/integration/dashboard.js

diff --git a/cypress/integration/dashboard.js b/cypress/integration/dashboard.js
new file mode 100644
index 0000000000..6eb28567bc
--- /dev/null
+++ b/cypress/integration/dashboard.js
@@ -0,0 +1,50 @@
+describe("Dashboard view", { scrollBehavior: false }, () => {
+	before(() => {
+		cy.login();
+		cy.visit("/app");
+	});
+
+	it("should load", () => {
+		const chart = "TODO-YEARLY-TRENDS";
+		const dashboard = "TODO-TEST-DASHBOARD"; // check slash in name intentionally.
+
+		cy.insert_doc(
+			"Dashboard Chart",
+			{
+				is_standard: 0,
+				chart_name: chart,
+				chart_type: "Count",
+				document_type: "ToDo",
+				parent_document_type: "",
+				based_on: "creation",
+				group_by_type: "Count",
+				timespan: "Last Year",
+				time_interval: "Yearly",
+				timeseries: 1,
+				type: "Line",
+				filters_json: "[]",
+			},
+			true
+		);
+
+		cy.insert_doc(
+			"Dashboard",
+			{
+				name: dashboard,
+				dashboard_name: dashboard,
+				is_standard: 0,
+				charts: [
+					{
+						chart: chart,
+					},
+				],
+			},
+			true
+		);
+
+		cy.visit(`/app/dashboard-view/${dashboard}`);
+
+		// expect chart to be loaded
+		cy.findByText(chart).should("be.visible");
+	});
+});