From b04899f4aef2ccf8684859c821857bca46603c33 Mon Sep 17 00:00:00 2001 From: pipech Date: Fri, 6 Mar 2026 14:39:10 +0700 Subject: [PATCH] fix(workflow): enable_action confirmation permission error * fix: workflow enable_action confirmation * style: apply formatting * fix: function name and handle response * Update frappe/public/js/frappe/form/workflow.js Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> * fix: remove unnecessary backend call * style(workflow): fix lint --------- Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> --- frappe/public/js/frappe/form/workflow.js | 26 +++++++++--------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/frappe/public/js/frappe/form/workflow.js b/frappe/public/js/frappe/form/workflow.js index 72e50feb0a..8088f2ac26 100644 --- a/frappe/public/js/frappe/form/workflow.js +++ b/frappe/public/js/frappe/form/workflow.js @@ -102,22 +102,16 @@ frappe.ui.form.States = class FormStates { if (frappe.user_roles.includes(d.allowed) && has_approval_access(d)) { added = true; me.frm.page.add_action_item(__(d.action), function () { - frappe.db - .get_value( - "Workflow", - { document_type: me.frm.doctype }, - "enable_action_confirmation" - ) - .then((r) => { - if (r.message.enable_action_confirmation) { - frappe.confirm( - __("Are you sure you want to {0}?", [d.action]), - () => me.handle_workflow_action(d) - ); - } else { - me.handle_workflow_action(d); - } - }); + if ( + frappe.workflow?.workflows?.[me.frm.doctype] + ?.enable_action_confirmation + ) { + frappe.confirm(__("Are you sure you want to {0}?", [d.action]), () => + me.handle_workflow_action(d) + ); + } else { + me.handle_workflow_action(d); + } }); } });