vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

perf: Speed up request_cache

Browse source 
Sped up request_cache access times multi-fold with the help of a
benchmarking script. Access times for this generic cache is comparable
to specific caches written (eg: get_meta's local cache) by an additional
overhead of 15% as compared to implementing it in each function separately

* Got rid of logging
* Optimized bits with the help of benchmarking script against
  frappe.get_meta's performance
* Use hash instead of json.dumps
This commit is contained in:
Gavin D'souza 2022-06-01 15:24:45 +05:30
parent 958745fbc0
commit b04e1908f1
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
frappe/utils/caching.py
View file

@ -12,9 +12,11 @@ import frappe
_SITE_CACHE = defaultdict(lambda: defaultdict(dict))
def __generate_request_cache_key(func: Callable, args: Tuple, kwargs: Dict):
def __generate_request_cache_key(args: Tuple, kwargs: Dict):
"""Generate a key for the cache."""
return f"{func.__module__}.{func.__name__}{json.dumps((args, kwargs))}"
if not kwargs:
return hash(args)
return hash((args, frozenset(kwargs.items())))
def request_cache(func: Callable) -> Callable:
@ -42,21 +44,19 @@ def request_cache(func: Callable) -> Callable:
if not getattr(frappe.local, "initialised", None):
return func(*args, **kwargs)
if not hasattr(frappe.local, "request_cache"):
frappe.local.request_cache = {}
logger = frappe.logger(module=__name__)
frappe.local.request_cache = defaultdict(dict)
try:
key = __generate_request_cache_key(func, args, kwargs)
args_key = __generate_request_cache_key(args, kwargs)
except Exception:
logger.warning(f"request_cache: Couldn't generate key for args: {args}, kwargs: {kwargs}")
return func(*args, **kwargs)
if key not in frappe.local.request_cache:
frappe.local.request_cache[key] = func(*args, **kwargs)
logger.debug(f"request_cache: Cached key {key}")
logger.debug(f"request_cache: Hit cache with key {key}")
return frappe.local.request_cache[key]
try:
return frappe.local.request_cache[func][args_key]
except KeyError:
return_val = func(*args, **kwargs)
frappe.local.request_cache[func][args_key] = return_val
return return_val
return wrapper