vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(UX): dont query options for doctype that dont exist

Browse source
This commit is contained in:
Ankush Menat 2022-05-30 17:50:57 +05:30
parent 22f2c78400
commit b0a7c47de7
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/core/doctype/document_naming_settings/document_naming_settings.py
View file

@ -167,9 +167,13 @@ class DocumentNamingSettings(Document):
)
@frappe.whitelist()
def get_options(self, arg=None):
if frappe.get_meta(arg or self.transaction_type).get_field("naming_series"):
return frappe.get_meta(arg or self.transaction_type).get_field("naming_series").options
def get_options(self, doctype=None):
doctype = doctype or self.transaction_type
if not doctype:
return
if frappe.get_meta(doctype or self.transaction_type).get_field("naming_series"):
return frappe.get_meta(doctype or self.transaction_type).get_field("naming_series").options
@frappe.whitelist()
def get_current(self, arg=None):

2
frappe/core/doctype/document_naming_settings/test_document_naming_settings.py
View file

@ -10,7 +10,7 @@ from frappe.tests.utils import FrappeTestCase
class TestNamingSeries(FrappeTestCase):
def setUp(self):
self.ns: DocumentNamingSettings = frappe.get_doc("Naming Series Settings")
self.ns: DocumentNamingSettings = frappe.get_doc("Document Naming Settings")
def tearDown(self):
frappe.db.rollback()