From b0bb0cf2c4864a1b97edf507a5733183c56c81e7 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Tue, 1 Jun 2021 01:32:19 +0530 Subject: [PATCH] refactor(minor): Use set comprehension instead of difference --- frappe/custom/doctype/customize_form/customize_form.py | 3 +-- .../doctype/global_search_settings/global_search_settings.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/frappe/custom/doctype/customize_form/customize_form.py b/frappe/custom/doctype/customize_form/customize_form.py index 9d613b207b..d397d8899d 100644 --- a/frappe/custom/doctype/customize_form/customize_form.py +++ b/frappe/custom/doctype/customize_form/customize_form.py @@ -355,8 +355,7 @@ class CustomizeForm(Document): def delete_custom_fields(self): meta = frappe.get_meta(self.doc_type) - fields_to_remove = (set(df.fieldname for df in meta.get("fields")) - - set(df.fieldname for df in self.get("fields"))) + fields_to_remove = {df.fieldname for df in meta.get("fields") if df not in self.get("fields")} for fieldname in fields_to_remove: df = meta.get("fields", {"fieldname": fieldname})[0] diff --git a/frappe/desk/doctype/global_search_settings/global_search_settings.py b/frappe/desk/doctype/global_search_settings/global_search_settings.py index f48e964959..9112349c1b 100644 --- a/frappe/desk/doctype/global_search_settings/global_search_settings.py +++ b/frappe/desk/doctype/global_search_settings/global_search_settings.py @@ -21,7 +21,7 @@ class GlobalSearchSettings(Document): dts.append(dt.document_type) if core_dts: - core_dts = (", ".join(frappe.bold(dt) for dt in core_dts)) + core_dts = ", ".join(frappe.bold(dt) for dt in core_dts) frappe.throw(_("Core Modules {0} cannot be searched in Global Search.").format(core_dts)) if repeated_dts: