From b1a04ed453cd40d7374d2f8b72d482bf4460ca12 Mon Sep 17 00:00:00 2001 From: prssanna Date: Mon, 1 Mar 2021 10:57:30 +0530 Subject: [PATCH] fix: reference doctype for saved report --- frappe/public/js/frappe/list/list_view_select.js | 7 ++++--- frappe/public/js/frappe/views/reports/report_view.js | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/frappe/public/js/frappe/list/list_view_select.js b/frappe/public/js/frappe/list/list_view_select.js index 58753b7550..826158ff3f 100644 --- a/frappe/public/js/frappe/list/list_view_select.js +++ b/frappe/public/js/frappe/list/list_view_select.js @@ -156,10 +156,11 @@ frappe.views.ListViewSelect = class ListViewSelect { items.map(item => { if (item.name.toLowerCase() == page_name.toLowerCase()) { placeholder = item.name; + } else { + html += `
  • ${ + item.name + }
  • `; } - html += `
  • ${ - item.name - }
  • `; }); } diff --git a/frappe/public/js/frappe/views/reports/report_view.js b/frappe/public/js/frappe/views/reports/report_view.js index e2e0080e6f..b29b6b87e6 100644 --- a/frappe/public/js/frappe/views/reports/report_view.js +++ b/frappe/public/js/frappe/views/reports/report_view.js @@ -1203,11 +1203,11 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView { // Rerender the reports dropdown, // so that this report is included in the dropdown as well. frappe.boot.user.all_reports[r.message] = { - ref_doctype: "Item", + ref_doctype: this.doctype, report_type: "Report Builder", title: r.message, }; - this.list_sidebar.setup_reports(); + frappe.set_route('List', this.doctype, 'Report', r.message); return; }