Merge pull request #10880 from Thunderbottom/s3-backup-fix

fix: only validate s3 settings if enabled
2020-06-30 12:43:43 +00:00 · 2020-06-30 12:43:43 +00:00 · b1bdb3286e
commit b1bdb3286e
parent 9dbe5f17d6 adadb26732
1 changed files with 3 additions and 0 deletions
--- a/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py
+++ b/frappe/integrations/doctype/s3_backup_settings/s3_backup_settings.py
@ -19,6 +19,9 @@ from botocore.exceptions import ClientError
 class S3BackupSettings(Document):

 	def validate(self):
+		if not self.enabled:
+			return
+
 		if not self.endpoint_url:
 			self.endpoint_url = 'https://s3.amazonaws.com'
 		conn = boto3.client(