From b1d55680a30a7d58d7713aba2bee72b3353aeda1 Mon Sep 17 00:00:00 2001 From: Pruthvi Patel Date: Thu, 10 Mar 2022 12:28:23 +0530 Subject: [PATCH] fix: Consider title field only if it's value exists (#16236) * fix: consider title field only if it's value exists * chore: make `title` bold --- frappe/public/js/frappe/model/model.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/frappe/public/js/frappe/model/model.js b/frappe/public/js/frappe/model/model.js index 62f8ec2f1e..fe959b259d 100644 --- a/frappe/public/js/frappe/model/model.js +++ b/frappe/public/js/frappe/model/model.js @@ -577,13 +577,15 @@ $.extend(frappe.model, { }, delete_doc: function(doctype, docname, callback) { - var title = docname; - var title_field = frappe.get_meta(doctype).title_field; + let title = docname; + const title_field = frappe.get_meta(doctype).title_field; if (frappe.get_meta(doctype).autoname == "hash" && title_field) { - var title = frappe.model.get_value(doctype, docname, title_field); - title += " (" + docname + ")"; + const value = frappe.model.get_value(doctype, docname, title_field); + if (value) { + title = `${value} (${docname})`; + } } - frappe.confirm(__("Permanently delete {0}?", [title]), function() { + frappe.confirm(__("Permanently delete {0}?", [title.bold()]), function() { return frappe.call({ method: 'frappe.client.delete', args: {