refactor: moved is_submittable validation from save to submission queue
This commit is contained in:
parent
563e3c06b0
commit
b33efdc634
2 changed files with 7 additions and 2 deletions
|
|
@ -74,7 +74,7 @@ class SubmissionQueue(Document):
|
|||
message = _("Submission of {0} {1} with action {2} completed successfully")
|
||||
|
||||
notification_doc = {
|
||||
"type": "Mention",
|
||||
"type": "Alert",
|
||||
"document_type": doctype,
|
||||
"document_name": docname,
|
||||
"subject": message.format(
|
||||
|
|
@ -128,6 +128,12 @@ class SubmissionQueue(Document):
|
|||
|
||||
|
||||
def queue_submission(doc: Document, action: str):
|
||||
# Allowing only submittable doctypes to be queued
|
||||
|
||||
if not doc.meta.is_submittable:
|
||||
getattr(doc, action.lower())()
|
||||
return
|
||||
|
||||
queue = frappe.new_doc("Submission Queue")
|
||||
queue.state = "Queued"
|
||||
queue.enqueued_by = frappe.session.user
|
||||
|
|
|
|||
|
|
@ -22,7 +22,6 @@ def savedocs(doc, action):
|
|||
if (
|
||||
action == "Submit"
|
||||
and doc.meta.queue_in_background
|
||||
and doc.meta.is_submittable
|
||||
and not is_scheduler_inactive()
|
||||
):
|
||||
queue_submission(doc, action)
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue