From b358c94a2e3402c575759bc45130aa620bc89741 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 28 Aug 2023 11:16:12 +0530 Subject: [PATCH] chore: use doc to update references --- .../automation/doctype/auto_repeat/auto_repeat.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/frappe/automation/doctype/auto_repeat/auto_repeat.py b/frappe/automation/doctype/auto_repeat/auto_repeat.py index dab10dcc0a..c36c009adf 100644 --- a/frappe/automation/doctype/auto_repeat/auto_repeat.py +++ b/frappe/automation/doctype/auto_repeat/auto_repeat.py @@ -554,15 +554,11 @@ def get_auto_repeat_doctypes(doctype, txt, searchfield, start, page_len, filters @frappe.whitelist() -def update_reference(docname, reference): - result = "" - try: - frappe.db.set_value("Auto Repeat", docname, "reference_document", reference) - result = "success" - except Exception as e: - result = "error" - raise e - return result +def update_reference(docname: str, reference: str): + doc = frappe.get_doc("Auto Repeat", str(docname)) + doc.check_permission("write") + doc.db_set("reference_document", str(reference)) + return "success" # backward compatbility @frappe.whitelist()