From b408bc92c5d427fd417bcdee98afda1f3cb5ab2f Mon Sep 17 00:00:00 2001 From: Luis Mendoza Date: Sat, 7 Feb 2026 03:15:17 -0300 Subject: [PATCH] fix: hide Submit button on non-submittable doctypes (#36825) can_submit() only checked docstatus, permissions, and workflow but never verified the doctype is actually submittable. Since all documents start at docstatus 0, this caused a Submit button to appear on any non-submittable doctype where the user has submit permission (e.g. System Manager). --- frappe/public/js/frappe/form/toolbar.js | 1 + 1 file changed, 1 insertion(+) diff --git a/frappe/public/js/frappe/form/toolbar.js b/frappe/public/js/frappe/form/toolbar.js index 6a80d18dfa..ed6b86045a 100644 --- a/frappe/public/js/frappe/form/toolbar.js +++ b/frappe/public/js/frappe/form/toolbar.js @@ -670,6 +670,7 @@ frappe.ui.form.Toolbar = class Toolbar { } can_submit() { return ( + frappe.model.is_submittable(this.frm.doc.doctype) && this.get_docstatus() === 0 && !this.frm.doc.__islocal && !this.frm.doc.__unsaved &&