Merge pull request #38882 from frappe/revert-38815-fix-client
Revert "fix(client): add stronger checks in save and set_value endpoints"
This commit is contained in:
commit
b42fc9baec
1 changed files with 11 additions and 19 deletions
|
|
@ -189,21 +189,18 @@ def set_value(doctype: str, name: str | int, fieldname: str | dict[str, Any], va
|
||||||
:param fieldname: fieldname string or JSON / dict with key value pair
|
:param fieldname: fieldname string or JSON / dict with key value pair
|
||||||
:param value: value if fieldname is JSON / dict"""
|
:param value: value if fieldname is JSON / dict"""
|
||||||
|
|
||||||
values = {}
|
if fieldname in (frappe.model.default_fields + frappe.model.child_table_fields):
|
||||||
if value is not None:
|
frappe.throw(_("Cannot edit standard fields"))
|
||||||
values = {fieldname: value}
|
|
||||||
elif isinstance(fieldname, dict):
|
|
||||||
values = fieldname
|
|
||||||
elif isinstance(fieldname, str):
|
|
||||||
try:
|
|
||||||
values = json.loads(fieldname)
|
|
||||||
except ValueError:
|
|
||||||
values = {fieldname: ""}
|
|
||||||
|
|
||||||
forbidden = set(frappe.model.default_fields + frappe.model.child_table_fields)
|
if not value:
|
||||||
for field in values:
|
values = fieldname
|
||||||
if field in forbidden:
|
if isinstance(fieldname, str):
|
||||||
frappe.throw(_("Cannot edit standard fields"))
|
try:
|
||||||
|
values = json.loads(fieldname)
|
||||||
|
except ValueError:
|
||||||
|
values = {fieldname: ""}
|
||||||
|
else:
|
||||||
|
values = {fieldname: value}
|
||||||
|
|
||||||
# check for child table doctype
|
# check for child table doctype
|
||||||
if not frappe.get_meta(doctype).istable:
|
if not frappe.get_meta(doctype).istable:
|
||||||
|
|
@ -253,11 +250,6 @@ def save(doc: str | dict[str, Any]):
|
||||||
if isinstance(doc, str):
|
if isinstance(doc, str):
|
||||||
doc = json.loads(doc)
|
doc = json.loads(doc)
|
||||||
|
|
||||||
forbidden = {"docstatus", "idx"}
|
|
||||||
for field in doc:
|
|
||||||
if field in forbidden:
|
|
||||||
frappe.throw(_("Cannot edit standard fields"))
|
|
||||||
|
|
||||||
doc = frappe.get_doc(doc)
|
doc = frappe.get_doc(doc)
|
||||||
doc.save()
|
doc.save()
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Reference in a new issue