vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #26783 from barredterra/kanban-no-empty-pop

Browse source 
fix: avoid popping from empty list
This commit is contained in:
Akhil Narang 2024-06-18 17:56:23 +05:30 • committed by GitHub
commit b5c2618972
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/desk/doctype/kanban_board/kanban_board.py
View file

@ -147,7 +147,8 @@ def update_order_for_single_card(board_name, docname, from_colname, to_colname,
if from_colname == to_colname:
from_col_order = to_col_order
to_col_order.insert(new_index, from_col_order.pop(old_index))
if from_col_order:
to_col_order.insert(new_index, from_col_order.pop(old_index))
# save updated order
board.columns[from_col_idx].order = frappe.as_json(from_col_order)