From 47be06931cc5d564b4d79713247009a7e4258d36 Mon Sep 17 00:00:00 2001
From: sokumon <sohamkulkarns9@gmail.com>
Date: Mon, 12 Jan 2026 15:01:01 +0530
Subject: [PATCH] fix: dont show report if the report iis not there

---
 frappe/public/js/frappe/ui/menu.js             |  2 +-
 .../js/frappe/ui/sidebar/sidebar_item.js       | 18 ++++++++++++------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/frappe/public/js/frappe/ui/menu.js b/frappe/public/js/frappe/ui/menu.js
index fd0f93e5db..02522dc2bd 100644
--- a/frappe/public/js/frappe/ui/menu.js
+++ b/frappe/public/js/frappe/ui/menu.js
@@ -21,7 +21,7 @@ frappe.ui.menu = class ContextMenu {
 				event.stopPropagation();
 				if (me.visible) {
 					me.hide();
-					me.opts.onHide && me.opts.onHide(me);
+					me.opts.onHide && me.opts.onHide(me.parent);
 				} else {
 					me.show(event);
 					me.opts.onShow && me.opts.onShow(me.parent);
diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js
index 139a7c125d..19e12a04be 100644
--- a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js
+++ b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js
@@ -19,12 +19,15 @@ frappe.ui.sidebar_item.TypeLink = class SidebarItem {
 					type: this.item.link_type,
 					name: this.item.link_to,
 				};
-
-				if (this.item.report || !frappe.app.sidebar.editor.edit_mode) {
-					args.is_query_report =
-						this.item.report.report_type === "Query Report" ||
-						this.item.report.report_type == "Script Report";
-					args.report_ref_doctype = this.item.report.ref_doctype;
+				if (!frappe.app.sidebar.editor.edit_mode) {
+					if (this.item.report) {
+						args.is_query_report =
+							this.item.report.report_type === "Query Report" ||
+							this.item.report.report_type == "Script Report";
+						args.report_ref_doctype = this.item.report.ref_doctype;
+					} else {
+						return;
+					}
 				}
 
 				path = frappe.utils.generate_route(args);
@@ -72,6 +75,9 @@ frappe.ui.sidebar_item.TypeLink = class SidebarItem {
 	prepare() {}
 	make() {
 		this.path = this.get_path();
+		if (!this.path && !this.item.standard && this.item.type != "Section Break") {
+			return;
+		}
 		this.set_suffix();
 		if (!this.item.icon && !(this.item.child && this.item.parent.indent)) {
 			this.item.icon = "list";