vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Revert "feat: auto-expand sidebar on hover"

Browse source
This commit is contained in:
Soham Kulkarni 2025-08-04 00:47:07 +05:30 • committed by GitHub
parent de2144b109
commit b756fb2803
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 65 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
frappe/public/js/frappe/ui/sidebar.js
View file

@ -50,59 +50,6 @@ frappe.ui.Sidebar = class Sidebar {
});
this.apps_switcher = new frappe.ui.AppsSwitcher(this);
this.apps_switcher.create_app_data_map();
// Add hover functionality for auto-expand
this.setup_hover_expand();
}
setup_hover_expand() {
const sidebar = this.wrapper.find(".body-sidebar");
const placeholder = this.wrapper.find(".body-sidebar-placeholder");
let hoverTimeout;
sidebar.on("mouseenter", () => {
// Only expand on hover if sidebar is collapsed and not on mobile
if (!this.sidebar_expanded && !frappe.is_mobile()) {
clearTimeout(hoverTimeout);
hoverTimeout = setTimeout(() => {
this.wrapper.addClass("hover-expanded");
}, 200); // Small delay to prevent accidental expansion
}
});
sidebar.on("mouseleave", () => {
// Only collapse on hover if sidebar is collapsed and not on mobile
if (!this.sidebar_expanded && !frappe.is_mobile()) {
clearTimeout(hoverTimeout);
hoverTimeout = setTimeout(() => {
this.wrapper.removeClass("hover-expanded");
}, 300); // Slightly longer delay to prevent accidental collapse
}
});
// Also handle hover on the placeholder to prevent collapse when moving to main content
placeholder.on("mouseenter", () => {
if (!this.sidebar_expanded && !frappe.is_mobile()) {
clearTimeout(hoverTimeout);
this.wrapper.addClass("hover-expanded");
}
});
// Handle mouse leave on placeholder as well
placeholder.on("mouseleave", () => {
if (!this.sidebar_expanded && !frappe.is_mobile()) {
clearTimeout(hoverTimeout);
hoverTimeout = setTimeout(() => {
this.wrapper.removeClass("hover-expanded");
}, 300);
}
});
// Clear hover state when manually toggling sidebar
this.wrapper.find(".body-sidebar .collapse-sidebar-link").on("click", () => {
clearTimeout(hoverTimeout);
this.wrapper.removeClass("hover-expanded");
});
}
set_hover() {
@ -322,12 +269,10 @@ frappe.ui.Sidebar = class Sidebar {
let direction;
if (this.sidebar_expanded) {
this.wrapper.addClass("expanded");
this.wrapper.removeClass("hover-expanded"); // Remove hover state when manually expanded
// this.sidebar_expanded = false
direction = "left";
} else {
this.wrapper.removeClass("expanded");
this.wrapper.removeClass("hover-expanded"); // Remove hover state when manually collapsed
// this.sidebar_expanded = true
direction = "right";
}

10
frappe/public/scss/desk/sidebar.scss
View file

@ -90,7 +90,6 @@ body {
height: 100vh;
z-index: 1030;
padding: 8px 8px 10px 8px;
transition: width 0.2s ease-in-out;
.body-sidebar-top {
flex: 1 1;
@ -290,15 +289,6 @@ body {
@include body-sidebar-expanded();
}
.body-sidebar-container.hover-expanded {
@include body-sidebar-expanded();
.body-sidebar {
// Ensure smooth transition for hover state
transition: width 0.2s ease-in-out;
}
}
@include media-breakpoint-down(sm) {
// body sidebar hidded in mobile view
.body-sidebar-container {