From b7bc5d3236a9f91f6fcc76f83fbe24414b0c0580 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 27 Mar 2024 14:29:04 +0530 Subject: [PATCH] fix(round 3): switch to creation sorting (#25669) --- frappe/desk/form/document_follow.py | 2 +- frappe/tests/test_db.py | 2 +- frappe/translate.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/desk/form/document_follow.py b/frappe/desk/form/document_follow.py index bae67792bc..ca301ffac9 100644 --- a/frappe/desk/form/document_follow.py +++ b/frappe/desk/form/document_follow.py @@ -156,7 +156,7 @@ def get_document_followed_by_user(user): frappe.qb.from_(DocumentFollow) .where(DocumentFollow.user == user) .select(DocumentFollow.ref_doctype, DocumentFollow.ref_docname) - .orderby(DocumentFollow.modified) + .orderby(DocumentFollow.creation) .limit(20) ).run(as_dict=True) diff --git a/frappe/tests/test_db.py b/frappe/tests/test_db.py index c1abd1798e..f5000e3f58 100644 --- a/frappe/tests/test_db.py +++ b/frappe/tests/test_db.py @@ -124,7 +124,7 @@ class TestDB(FrappeTestCase): ).lower(), ) self.assertEqual( - frappe.db.sql("select email from tabUser where name='Administrator' order by modified DESC"), + frappe.db.sql("select email from tabUser where name='Administrator' order by creation DESC"), frappe.db.get_values("User", filters=[["name", "=", "Administrator"]], fieldname="email"), ) diff --git a/frappe/translate.py b/frappe/translate.py index 66e0e768ed..1913b1d9b3 100644 --- a/frappe/translate.py +++ b/frappe/translate.py @@ -129,7 +129,7 @@ def set_default_language(lang): def get_lang_dict(): """Return all languages in dict format, full name is the key e.g. `{"english":"en"}`.""" return dict( - frappe.get_all("Language", fields=["language_name", "name"], order_by="modified", as_list=True) + frappe.get_all("Language", fields=["language_name", "name"], order_by="creation", as_list=True) )