From b80ef0d89e6a526e35a819e6a74c13fd1d5b2d6a Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Mon, 29 Dec 2025 17:02:17 +0530 Subject: [PATCH] fix: correct some type annotations changed by ruff Reference: commit 8723a2b6ee9dbec800077f18202ba53b0ef553e7 These didn't need to be forward references Signed-off-by: Akhil Narang --- frappe/core/doctype/permission_log/permission_log.py | 6 +++--- frappe/desk/search.py | 5 +---- frappe/utils/data.py | 6 +++--- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/frappe/core/doctype/permission_log/permission_log.py b/frappe/core/doctype/permission_log/permission_log.py index 18e5fbd0cb..5f8d5a4e75 100644 --- a/frappe/core/doctype/permission_log/permission_log.py +++ b/frappe/core/doctype/permission_log/permission_log.py @@ -43,9 +43,9 @@ def make_perm_log(doc, method=None): def insert_perm_log( doc: Document, doc_before_save: Document = None, - for_doctype: "str" | None = None, - for_document: "str" | None = None, - fields: "list | tuple" | None = None, + for_doctype: str | None = None, + for_document: str | None = None, + fields: list | tuple | None = None, ): if frappe.flags.in_install or frappe.flags.in_migrate: # no need to log changes when migrating or installing app/site diff --git a/frappe/desk/search.py b/frappe/desk/search.py index 46ed85fec7..6c03de8d37 100644 --- a/frappe/desk/search.py +++ b/frappe/desk/search.py @@ -3,10 +3,7 @@ import json import re -from typing import ( - NotRequired, # not required in 3.11+ - TypedDict, -) +from typing import NotRequired, TypedDict import frappe diff --git a/frappe/utils/data.py b/frappe/utils/data.py index 33d17c4d7f..d2651006bf 100644 --- a/frappe/utils/data.py +++ b/frappe/utils/data.py @@ -116,7 +116,7 @@ def is_invalid_date_string(date_string: str) -> bool: def getdate( - string_date: "DateTimeLikeObject" | None = None, parse_day_first: bool = False + string_date: DateTimeLikeObject | None = None, parse_day_first: bool = False ) -> datetime.date | None: """ Convert string date (yyyy-mm-dd) to datetime.date object. @@ -148,7 +148,7 @@ def getdate( def get_datetime( - datetime_str: "DateTimeLikeObject" | None | tuple | list = None, + datetime_str: DateTimeLikeObject | None | tuple | list = None, ) -> datetime.datetime | None: """Return the below mentioned values based on the given `datetime_str`: @@ -373,7 +373,7 @@ def now_datetime() -> datetime.datetime: return datetime.datetime.now(ZoneInfo(get_system_timezone())).replace(tzinfo=None) -def get_timestamp(date: "DateTimeLikeObject" | None = None) -> float: +def get_timestamp(date: DateTimeLikeObject | None = None) -> float: """Return the Unix timestamp (seconds since Epoch) for the given `date`. If `date` is None, the current timestamp is returned. """