From b8549a53e50b81896cc121ed6db31391f0d6a0df Mon Sep 17 00:00:00 2001 From: KerollesFathy Date: Mon, 9 Mar 2026 21:18:19 +0000 Subject: [PATCH] fix(ux): add confirm before logout --- frappe/desk/page/desktop/desktop.js | 4 +++- frappe/public/js/frappe/ui/sidebar/sidebar_header.js | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/frappe/desk/page/desktop/desktop.js b/frappe/desk/page/desktop/desktop.js index bd294d75de..40d601292a 100644 --- a/frappe/desk/page/desktop/desktop.js +++ b/frappe/desk/page/desktop/desktop.js @@ -486,7 +486,9 @@ class DesktopPage { icon: "log-out", label: "Logout", onClick: function () { - frappe.app.logout(); + frappe.confirm(__("Are you sure you want to logout?"), () => { + return frappe.app.logout(); + }); }, }, ]; diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar_header.js b/frappe/public/js/frappe/ui/sidebar/sidebar_header.js index c587f3ae1d..5649e0d2d1 100644 --- a/frappe/public/js/frappe/ui/sidebar/sidebar_header.js +++ b/frappe/public/js/frappe/ui/sidebar/sidebar_header.js @@ -82,7 +82,9 @@ frappe.ui.SidebarHeader = class SidebarHeader { label: "Logout", icon: "logout", onClick: function () { - return frappe.app.logout(); + frappe.confirm(__("Are you sure you want to logout?"), () => { + return frappe.app.logout(); + }); }, } );