From c881eb7e45f93af28dae41fe9e942bca5d2469bc Mon Sep 17 00:00:00 2001 From: Alirio Castro Date: Mon, 15 Jun 2020 20:15:56 -0400 Subject: [PATCH 1/2] fix: pass silent as an arg to frappe.request.call --- frappe/public/js/frappe/request.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/frappe/public/js/frappe/request.js b/frappe/public/js/frappe/request.js index ea4de99249..9cf2e1b367 100644 --- a/frappe/public/js/frappe/request.js +++ b/frappe/public/js/frappe/request.js @@ -101,6 +101,11 @@ frappe.call = function(opts) { error_handlers: opts.error_handlers || {}, // show_spinner: !opts.no_spinner, async: opts.async, + /* + this property is evaluated in frappe.request.cleanup, however there is not way to pass this argument, and it is very important + to avoid the msgprint dialog when you are calling and get an unknown exception, mostly when you are calling in batches + */ + silent: opts.silent, url, }); } From dd18d91878151c5ea284fefa46fc637fb3181049 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Wed, 24 Jun 2020 18:49:05 +0530 Subject: [PATCH 2/2] refactor: remove unnecessary comment --- frappe/public/js/frappe/request.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/frappe/public/js/frappe/request.js b/frappe/public/js/frappe/request.js index 9cf2e1b367..0a5f5e7f6b 100644 --- a/frappe/public/js/frappe/request.js +++ b/frappe/public/js/frappe/request.js @@ -101,10 +101,6 @@ frappe.call = function(opts) { error_handlers: opts.error_handlers || {}, // show_spinner: !opts.no_spinner, async: opts.async, - /* - this property is evaluated in frappe.request.cleanup, however there is not way to pass this argument, and it is very important - to avoid the msgprint dialog when you are calling and get an unknown exception, mostly when you are calling in batches - */ silent: opts.silent, url, });