vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Setting default print format (#19862)

Browse source 
- Remove check for developer mode, it's not even valid as we dont allow
  setting default print format like this
- Set in custom doctype if custom doctype else prop setter.
- query meta instead of doctype.

[skip ci]
This commit is contained in:
Ankush Menat 2023-01-31 17:52:35 +05:30 • committed by GitHub
parent 4d08f50a03
commit b8ba7dcdb3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
frappe/printing/doctype/print_format/print_format.js
View file

@ -40,20 +40,23 @@ frappe.ui.form.on("Print Format", {
frm.set_df_property("html", "reqd", 1);
}
if (frappe.model.can_write("Customize Form")) {
frappe.db.get_value("DocType", frm.doc.doc_type, "default_print_format", (r) => {
if (r.default_print_format != frm.doc.name) {
frm.add_custom_button(__("Set as Default"), function () {
frappe.call({
method: "frappe.printing.doctype.print_format.print_format.make_default",
args: {
name: frm.doc.name,
},
callback: function () {
frm.refresh();
},
});
});
frappe.model.with_doctype(frm.doc.doc_type, function () {
let current_format = frappe.get_meta(frm.doc.DocType).default_print_format;
if (current_format == frm.doc.name) {
return;
}
frm.add_custom_button(__("Set as Default"), function () {
frappe.call({
method: "frappe.printing.doctype.print_format.print_format.make_default",
args: {
name: frm.doc.name,
},
callback: function () {
frm.refresh();
},
});
});
});
}
}

7
frappe/printing/doctype/print_format/print_format.py
View file

@ -109,13 +109,12 @@ def make_default(name):
print_format = frappe.get_doc("Print Format", name)
if (frappe.conf.get("developer_mode") or 0) == 1:
# developer mode, set it default in doctype
doctype = frappe.get_doc("DocType", print_format.doc_type)
doctype = frappe.get_doc("DocType", print_format.doc_type)
if doctype.custom:
doctype.default_print_format = name
doctype.save()
else:
# customization
# "Customize form"
frappe.make_property_setter(
{
"doctype_or_field": "DocType",