From ba5ec5bcc86ee802f0f923f2e41a0deb64768f8c Mon Sep 17 00:00:00 2001
From: Rushabh Mehta <rmehta@gmail.com>
Date: Tue, 20 Mar 2018 11:40:32 +0530
Subject: [PATCH] [fix] fix ajax call to update doc not replace (#5204)

---
 frappe/public/js/frappe/model/sync.js | 36 ++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/frappe/public/js/frappe/model/sync.js b/frappe/public/js/frappe/model/sync.js
index 645585b082..ddcd587695 100644
--- a/frappe/public/js/frappe/model/sync.js
+++ b/frappe/public/js/frappe/model/sync.js
@@ -20,7 +20,12 @@ $.extend(frappe.model, {
 			for(var i=0, l=r.docs.length; i<l; i++) {
 				var d = r.docs[i];
 
-				frappe.model.add_to_locals(d);
+				if (locals[d.doctype] && locals[d.doctype][d.name]) {
+					// update values
+					frappe.model.update_in_locals(d);
+				} else {
+					frappe.model.add_to_locals(d);
+				}
 
 				d.__last_sync_on = new Date();
 
@@ -97,6 +102,35 @@ $.extend(frappe.model, {
 				}
 			}
 		}
+	},
+	update_in_locals: function(d) {
+		// update values in the existing local doc instead of replacing
+		let local_doc = locals[d.doctype][d.name];
+		for (let fieldname in d) {
+			if (local_doc[fieldname] instanceof Array) {
+				// table
+				if (!(d[fieldname] instanceof Array)) {
+					d[fieldname] = [];
+				}
+				// child table, override each row and append new rows if required
+				for (let i=0; i < d[fieldname].length; i++ ) {
+					if (local_doc[fieldname][i]) {
+						// row exists, just copy the values
+						Object.assign(local_doc[fieldname][i], d[fieldname][i]);
+					} else {
+						local_doc[fieldname].push(d[fieldname][i]);
+					}
+				}
+
+				// remove extra rows
+				if (local_doc[fieldname].length > d[fieldname].length) {
+					local_doc[fieldname].length = d[fieldname].length;
+				}
+			} else {
+				// literal
+				local_doc[fieldname] = d[fieldname];
+			}
+		}
 	}
 
 });