vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Listview fixes (#4846)

Browse source 
* [minor] Handle empty fieldselect map

* Handle 0 rows in reportview
This commit is contained in:
Faris Ansari 2018-01-18 14:50:54 +05:30 • committed by GitHub
parent 7c6efd2e24
commit ba9818a61e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/public/js/frappe/ui/filters/filter.js
View file

@ -115,7 +115,7 @@ frappe.ui.Filter = class {
let cur = {};
if(this.field) for(let k in this.field.df) cur[k] = this.field.df[k];
let original_docfield = this.fieldselect.fields_by_name[doctype][fieldname];
let original_docfield = (this.fieldselect.fields_by_name[doctype] || {})[fieldname];
if(!original_docfield) {
frappe.msgprint(__("Field {0} is not selectable.", [fieldname]));
return;

2
frappe/public/js/frappe/views/reports/report_view.js
View file

@ -63,6 +63,8 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
}
render() {
if (this.data.length === 0) return;
if (this.datatable) {
this.datatable.refresh(this.get_data(this.data));
return;