vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: remove unused image mixins

Browse source
This commit is contained in:
prssanna 2021-02-12 11:21:58 +05:30
parent d2720c610a
commit bab0fbf692
3 changed files with 75 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
frappe/public/less/desk.less
View file

@ -694,49 +694,39 @@
// }
.img-background() {
content: " ";
display: block;
position: absolute;
left: 0;
height: calc(100%);
width: 100%;
background-color: @light-bg;
}
// .img-foreground() {
// content: "\f1c5";
// display: block;
// font-style: normal;
// font-family: FontAwesome;
// font-size: 32px;
// color: @text-extra-muted;
.img-foreground() {
content: "\f1c5";
display: block;
font-style: normal;
font-family: FontAwesome;
font-size: 32px;
color: @text-extra-muted;
// position: absolute;
// top: 50%;
// transform: translateY(-50%);
// left: 0;
// width: 100%;
// text-align: center;
// }
position: absolute;
top: 50%;
transform: translateY(-50%);
left: 0;
width: 100%;
text-align: center;
}
// img.no-image:before {
// .img-background();
// }
img.no-image:before {
.img-background();
}
// img.no-image:after {
// .img-foreground();
// }
img.no-image:after {
.img-foreground();
}
// img.img-loading:before {
// .img-background();
// }
img.img-loading:before {
.img-background();
}
img.img-loading:after {
.img-foreground();
font-family: 'Octicons';
content: "\f00b";
}
// img.img-loading:after {
// .img-foreground();
// font-family: 'Octicons';
// content: "\f00b";
// }
// utilities

26
frappe/public/scss/common/mixins.scss
View file

@ -26,3 +26,29 @@
transition: $property $duration $timing-fn;
-webkit-transition: $property $duration $timing-fn;
}
@mixin img-background() {
content: " ";
display: block;
position: absolute;
left: 0;
height: calc(100%);
width: 100%;
background-color: var(--bg-light-gray);
}
// @mixin img-foreground() {
// content: "\f1c5";
// display: block;
// font-style: normal;
// font-family: FontAwesome;
// font-size: 32px;
// color: var(--text-muted);
// position: absolute;
// top: 50%;
// transform: translateY(-50%);
// left: 0;
// width: 100%;
// text-align: center;
// }

22
frappe/public/scss/desk/global.scss
View file

@ -476,4 +476,24 @@ body.no-sidebar {
.alt-pressed .alt-underline {
text-decoration: underline;
}
}
// REDESIGN TODO: Handling of broken images?
// img.no-image:before {
// .img-background();
// }
// img.no-image:after {
// .img-foreground();
// }
// img.img-loading:before {
// .img-background();
// }
// img.img-loading:after {
// .img-foreground();
// font-family: 'Octicons';
// content: "\f00b";
// }