From bae02075d69eae7737471cde4e6c967fe7cd230a Mon Sep 17 00:00:00 2001
From: Mangesh-Khairnar <mkhairnar10@gmail.com>
Date: Fri, 8 May 2020 12:30:52 +0530
Subject: [PATCH] fix: remove reviews label on disabling energy points settings

---
 frappe/public/js/frappe/form/controls/rating.js             | 2 +-
 frappe/public/js/frappe/form/sidebar/review.js              | 6 ++++++
 frappe/public/js/frappe/form/templates/form_sidebar.html    | 5 +----
 .../doctype/energy_point_settings/energy_point_settings.js  | 4 +++-
 4 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/frappe/public/js/frappe/form/controls/rating.js b/frappe/public/js/frappe/form/controls/rating.js
index 9a68cec2be..34e890d45c 100644
--- a/frappe/public/js/frappe/form/controls/rating.js
+++ b/frappe/public/js/frappe/form/controls/rating.js
@@ -16,7 +16,7 @@ frappe.ui.form.ControlRating  = frappe.ui.form.ControlInt.extend({
 		$(this.input_area).find('i').hover((ev) => {
 			const el = $(ev.currentTarget);
 			let star_value = el.data('rating');
-			el.parent().children('i.fa').each( function(e){
+			el.parent().children('i.fa').each( function(e) {
 				if (e < star_value) {
 					$(this).addClass('star-hover');
 				} else {
diff --git a/frappe/public/js/frappe/form/sidebar/review.js b/frappe/public/js/frappe/form/sidebar/review.js
index e187ca4693..2cf2980bf7 100644
--- a/frappe/public/js/frappe/form/sidebar/review.js
+++ b/frappe/public/js/frappe/form/sidebar/review.js
@@ -21,6 +21,12 @@ frappe.ui.form.Review = class Review {
 		});
 	}
 	make_review_container() {
+		this.parent.append(`
+			<ul class="list-unstyled sidebar-menu">
+				<li class="h6 reviews-label">${__('Reviews')}</li>
+				<li class="review-list"></li>
+			</ul>
+		`);
 		this.review_list_wrapper = this.parent.find('.review-list');
 	}
 	add_review_button() {
diff --git a/frappe/public/js/frappe/form/templates/form_sidebar.html b/frappe/public/js/frappe/form/templates/form_sidebar.html
index 30b2205bae..c3f2de9c7e 100644
--- a/frappe/public/js/frappe/form/templates/form_sidebar.html
+++ b/frappe/public/js/frappe/form/templates/form_sidebar.html
@@ -69,10 +69,7 @@
 		<div class="clearfix"></div>
 	</li>
 </ul>
-<ul class="list-unstyled sidebar-menu form-reviews">
-	<li class="h6 attachments-label">{%= __("Reviews") %}</li>
-	<li class="review-list"></li>
-</ul>
+<span class="form-reviews"></span>
 <ul class="list-unstyled sidebar-menu">
 	<li class="h6 shared-with-label">{%= __("Shared With") %}</li>
 	<li class="form-shared"></li>
diff --git a/frappe/social/doctype/energy_point_settings/energy_point_settings.js b/frappe/social/doctype/energy_point_settings/energy_point_settings.js
index f061f4d74e..880e1866ea 100644
--- a/frappe/social/doctype/energy_point_settings/energy_point_settings.js
+++ b/frappe/social/doctype/energy_point_settings/energy_point_settings.js
@@ -3,7 +3,9 @@
 
 frappe.ui.form.on('Energy Point Settings', {
 	refresh: function(frm) {
-		frm.add_custom_button(__('Give Review Points'), show_review_points_dialog);
+		if (frm.doc.enabled) {
+			frm.add_custom_button(__('Give Review Points'), show_review_points_dialog);
+		}
 	}
 });