From bbfb26aaab9f466a0e3edf62473ee827cec0c687 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Fri, 24 Jan 2025 16:51:16 +0530 Subject: [PATCH] refactor(printview): first check for doc permissions, then for website This broke for some cases because people had doc permissions, but `has_website_permission()` returns False Signed-off-by: Akhil Narang --- frappe/www/printview.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/www/printview.py b/frappe/www/printview.py index e2c1c77872..ebe382ecc5 100644 --- a/frappe/www/printview.py +++ b/frappe/www/printview.py @@ -375,13 +375,13 @@ def get_rendered_raw_commands(doc: str, name: str | None = None, print_format: s def validate_print_permission(doc: "Document") -> None: - if frappe.has_website_permission(doc): - return - for ptype in ("read", "print"): if frappe.has_permission(doc.doctype, ptype, doc): return + if frappe.has_website_permission(doc): + return + if (key := frappe.form_dict.key) and isinstance(key, str): validate_key(key, doc) return