From bc81e340c784eb1aa9f9bc140229dac9ba8134f4 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Wed, 5 Mar 2025 11:25:54 +0100 Subject: [PATCH] fix: Move on_session_creation hook after session is created --- frappe/auth.py | 5 ++--- frappe/utils/oauth.py | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/frappe/auth.py b/frappe/auth.py index dd7f76d938..7c2302d4a8 100644 --- a/frappe/auth.py +++ b/frappe/auth.py @@ -125,9 +125,6 @@ class LoginManager: if self.login() is False: return self.resume = False - - # run login triggers - self.run_trigger("on_session_creation") else: try: self.resume = True @@ -233,6 +230,8 @@ class LoginManager: self.user = frappe.local.session_obj.user frappe.local.session = frappe.local.session_obj.data self.clear_active_sessions() + if not resume: + self.run_trigger("on_session_creation") def clear_active_sessions(self): """Clear other sessions of the current user if `deny_multiple_sessions` is not set""" diff --git a/frappe/utils/oauth.py b/frappe/utils/oauth.py index 6f62d72dc5..d41304084b 100644 --- a/frappe/utils/oauth.py +++ b/frappe/utils/oauth.py @@ -205,7 +205,6 @@ def login_oauth_user( ) frappe.local.login_manager.login_as(user) - frappe.local.login_manager.run_trigger("on_session_creation") # because of a GET request! frappe.db.commit()