From bca63f8e463248bc8a5c513ddba7b3188d24334b Mon Sep 17 00:00:00 2001 From: phot0n Date: Fri, 26 Aug 2022 17:35:48 +0530 Subject: [PATCH] chore: remove unused update_log_for_doc_creation flag * chore: add note/warning for log_types --- frappe/model/__init__.py | 2 ++ frappe/model/document.py | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/frappe/model/__init__.py b/frappe/model/__init__.py index 29991fa403..a7f966ebd6 100644 --- a/frappe/model/__init__.py +++ b/frappe/model/__init__.py @@ -114,6 +114,8 @@ core_doctypes_list = ( "Client Script", ) +# NOTE: this is being used for dynamic autoincrement in new sites, +# removing any of these will require patches. log_types = ( "Version", "Error Log", diff --git a/frappe/model/document.py b/frappe/model/document.py index 2a82b5af9a..aa3170b4ce 100644 --- a/frappe/model/document.py +++ b/frappe/model/document.py @@ -275,9 +275,6 @@ class Document(BaseDocument): if self.get("amended_from"): self.copy_attachments_from_amended_from() - # flag to prevent creation of event update log for create and update both - # during document creation - self.flags.update_log_for_doc_creation = True self.run_post_save_methods() self.flags.in_insert = False