From bcac30836bd69cde80b516e64ce2af3d512dc13e Mon Sep 17 00:00:00 2001
From: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
Date: Tue, 2 Dec 2025 00:19:44 +0530
Subject: [PATCH] refactor: remove redundant share check in
 check_read_permission

has_permission() already checks for shared documents internally when
role permissions do not grant access, so the separate frappe.share.get_shared()
call was dead code.
---
 frappe/database/query.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/frappe/database/query.py b/frappe/database/query.py
index 8bf56e9a01..9c2ef4e1c5 100644
--- a/frappe/database/query.py
+++ b/frappe/database/query.py
@@ -1154,12 +1154,10 @@ class Engine:
 			)
 
 		if not has_permission("select") and not has_permission("read"):
-			# Check for shared documents
-			if not frappe.share.get_shared(self.doctype, self.user):
-				frappe.throw(
-					_("Insufficient Permission for {0}").format(frappe.bold(self.doctype)),
-					frappe.PermissionError,
-				)
+			frappe.throw(
+				_("Insufficient Permission for {0}").format(frappe.bold(self.doctype)),
+				frappe.PermissionError,
+			)
 
 	def apply_field_permissions(self):
 		"""Filter the list of fields based on permlevel."""