vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: pickle doc objects directly

Browse source 
This seems to be missed out and causes performance regression in IRL
usage when get_doc is called on cached doc already.
This commit is contained in:
Ankush Menat 2022-09-18 01:05:29 +05:30
parent abd018773b
commit bcb5fe91aa
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/__init__.py
View file

@ -1089,17 +1089,20 @@ def get_cached_doc(*args, **kwargs) -> "Document":
if not key:
key = get_document_cache_key(doc.doctype, doc.name)
local.document_cache[key] = doc
_set_document_in_cache(key, doc)
return doc
def _set_document_in_cache(key: str, doc: "Document") -> None:
# Avoid setting in local.cache since we're already using local.document_cache above
# Try pickling the doc object as-is first, else fallback to doc.as_dict()
local.document_cache[key] = doc
try:
cache().hset("document_cache", key, doc, cache_locally=False)
except Exception:
cache().hset("document_cache", key, doc.as_dict(), cache_locally=False)
return doc
def can_cache_doc(args) -> str | None:
"""
@ -1174,13 +1177,10 @@ def get_doc(*args, **kwargs) -> "Document":
doc = frappe.model.document.get_doc(*args, **kwargs)
# Replace cache
# Replace cache if stale one exists
if key := can_cache_doc(args):
if key in local.document_cache:
local.document_cache[key] = doc
if cache().hexists("document_cache", key):
cache().hset("document_cache", key, doc.as_dict())
_set_document_in_cache(key, doc)
return doc