vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Extract header/footer html into content to simplify things

Browse source 
- Extract header/footer html into `content` first, then remove any instances from the main content since it is already rendered via the extracted header/footer html
This commit is contained in:
marination 2024-01-29 13:25:45 +01:00
parent f77b99396e
commit bcca1da8d8
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
frappe/utils/pdf.py
View file

@ -238,7 +238,13 @@ def prepare_header_footer(soup: BeautifulSoup):
# extract header and footer
for html_id in ("header-html", "footer-html"):
if content := soup.find(id=html_id):
if content := soup.find(id=html_id).extract():
# `header/footer-html` are extracted, rendered as html
# and passed in wkhtmltopdf options (as '--header/footer-html')
# Remove instances of them from main content for render_template
for tag in soup.find_all(id=html_id):
tag.extract()
toggle_visible_pdf(content)
id_map = {"header-html": "pdf_header_html", "footer-html": "pdf_footer_html"}
hook_func = frappe.get_hooks(id_map.get(html_id))
@ -251,10 +257,6 @@ def prepare_header_footer(soup: BeautifulSoup):
css=css,
)
# there could be multiple instances of header-html/footer-html
for tag in soup.find_all(id=html_id):
tag.extract()
# create temp file
fname = os.path.join("/tmp", f"frappe-pdf-{frappe.generate_hash()}.html")
with open(fname, "wb") as f: