From bd044e520c1b6b78ceeb62da2d39376ebcecd4c9 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Mon, 24 Nov 2025 11:13:43 +0530 Subject: [PATCH] fix(query): don't allow using `Document` as a filter value (#34823) Signed-off-by: Akhil Narang --- frappe/database/query.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frappe/database/query.py b/frappe/database/query.py index b034aa7812..94f992ed5e 100644 --- a/frappe/database/query.py +++ b/frappe/database/query.py @@ -20,6 +20,7 @@ from frappe.database.utils import ( ) from frappe.model import get_permitted_fields from frappe.model.base_document import DOCTYPES_FOR_DOCTYPE +from frappe.model.document import Document from frappe.query_builder import Criterion, Field, Order, functions from frappe.query_builder.custom import Month, MonthName, Quarter from frappe.query_builder.utils import PseudoColumnMapper @@ -454,6 +455,9 @@ class Engine: else: # Regular value processing for literal comparisons like: table.field = 'value' _value = convert_to_value(value) + + if isinstance(value, Document): + frappe.throw(_("Document cannot be used as a filter value")) _operator = operator # For Date fields with datetime values, convert to date to match db_query behavior