From d0eb066fa44189f25d714e1e00fe4a9b58a8bced Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Thu, 21 Mar 2019 16:49:35 +0530 Subject: [PATCH 1/5] Variable bleed in response --- frappe/utils/response.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/utils/response.py b/frappe/utils/response.py index 07bd85c980..ca563e5a3b 100644 --- a/frappe/utils/response.py +++ b/frappe/utils/response.py @@ -106,7 +106,8 @@ def make_logs(response = None): if frappe.error_log: response['exc'] = json.dumps([frappe.utils.cstr(d["exc"]) for d in frappe.local.error_log]) - response['locals'] = json.dumps([frappe.utils.cstr(d["locals"]) for d in frappe.local.error_log]) + if frappe.conf.developer_mode: + response['locals'] = json.dumps([frappe.utils.cstr(d["locals"]) for d in frappe.local.error_log]) if frappe.local.message_log: response['_server_messages'] = json.dumps([frappe.utils.cstr(d) for From 349132f3928a6e8da5119076c7daef5ad71ad1e6 Mon Sep 17 00:00:00 2001 From: scmmishra Date: Fri, 22 Mar 2019 15:00:16 +0530 Subject: [PATCH 2/5] fix: Proxied validate_email_add --- frappe/utils/__init__.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/frappe/utils/__init__.py b/frappe/utils/__init__.py index b3b46696bb..d65819edcb 100644 --- a/frappe/utils/__init__.py +++ b/frappe/utils/__init__.py @@ -75,6 +75,12 @@ def extract_email_id(email): return email_id def validate_email_add(email_str, throw=False): + """ + validate_email_add will be renamed to the validate_email_address in v12 + """ + return validate_email_address(email_str, throw=False) + +def validate_email_address(email_str, throw=False): """Validates the email string""" email = email_str = (email_str or "").strip() From 44a2180d1a6f20612bc155b4b3dd1b5ca83e62a5 Mon Sep 17 00:00:00 2001 From: Sahil Khan Date: Fri, 22 Mar 2019 15:41:30 +0530 Subject: [PATCH 3/5] fix: proxied 'validate_email_add' --- frappe/utils/__init__.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/frappe/utils/__init__.py b/frappe/utils/__init__.py index b3b46696bb..16572caa24 100644 --- a/frappe/utils/__init__.py +++ b/frappe/utils/__init__.py @@ -75,6 +75,12 @@ def extract_email_id(email): return email_id def validate_email_add(email_str, throw=False): + """ + validate_email_add will be renamed to the validate_email_address in v12 + """ + return validate_email_address(email_str, throw=False) + + def validate_email_address(email_str, throw=False): """Validates the email string""" email = email_str = (email_str or "").strip() From 946cea700afd535c51b8df77bc78c923ca825035 Mon Sep 17 00:00:00 2001 From: khadijazaki Date: Fri, 22 Mar 2019 17:38:35 +0500 Subject: [PATCH 4/5] fixed indentation error --- frappe/utils/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/utils/__init__.py b/frappe/utils/__init__.py index 16572caa24..d65819edcb 100644 --- a/frappe/utils/__init__.py +++ b/frappe/utils/__init__.py @@ -80,7 +80,7 @@ def validate_email_add(email_str, throw=False): """ return validate_email_address(email_str, throw=False) - def validate_email_address(email_str, throw=False): +def validate_email_address(email_str, throw=False): """Validates the email string""" email = email_str = (email_str or "").strip() From 30bc0f95ad9bfc539ed93e2ceac8cf7f8af544a6 Mon Sep 17 00:00:00 2001 From: Frappe Bot Date: Sat, 23 Mar 2019 07:21:22 +0000 Subject: [PATCH 5/5] bumped to version 11.1.16 --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index f7d62c22c1..d9b3b8d7b5 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -24,7 +24,7 @@ if sys.version[0] == '2': reload(sys) sys.setdefaultencoding("utf-8") -__version__ = '11.1.15' +__version__ = '11.1.16' __title__ = "Frappe Framework" local = Local()