From bda37b541b43a3288fb08ac972fb1ce372d148eb Mon Sep 17 00:00:00 2001 From: leela Date: Tue, 30 Mar 2021 12:04:09 +0530 Subject: [PATCH] refactor: Cleanup name confusion Using `delete_session` name for a function and also as a method name is confusing. Cleaned that up. (cherry picked from commit 9200192c1cbb2125894aa59150f361d031d55afb) --- frappe/sessions.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frappe/sessions.py b/frappe/sessions.py index 3babf1db12..5f13dfb7af 100644 --- a/frappe/sessions.py +++ b/frappe/sessions.py @@ -296,8 +296,7 @@ class Session: expiry = get_expiry_in_seconds(session_data.get("session_expiry")) if self.time_diff > expiry: - print('deleting...') - self.delete_session() + self._delete_session() data = None return data and data.data @@ -316,12 +315,12 @@ class Session: data = frappe._dict(eval(rec and rec[0][1] or '{}')) data.user = rec[0][0] else: - self.delete_session() + self._delete_session() data = None return data - def delete_session(self): + def _delete_session(self): delete_session(self.sid, reason="Session Expired") def start_as_guest(self):