vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: ignore no value fields when checking mandatory fields

Browse source
This commit is contained in:
Jannat Patel 2025-11-28 14:46:20 +05:30
parent 7514145781
commit be4f2a474c
1 changed files with 26 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
frappe/core/doctype/data_import/importer.py
View file

@ -458,23 +458,6 @@ class ImportFile:
if content:
return self.read_content(content, extension)
def validate_data_from_template_file(self, data):
meta = frappe.get_meta(self.doctype)
mandatory_fields = [df.label for df in meta.fields if df.reqd and df.fieldname not in no_value_fields]
headers = data[0] if data else []
if not headers:
frappe.throw(_("Import template should contain a Header row."), title=_("Template Error"))
for field in mandatory_fields:
if field not in headers:
frappe.throw(
_(
"Mandatory field {0} is missing in the import template for {1}. Please correct the template and try again."
).format(frappe.bold(field), frappe.bold(self.doctype)),
title=_("Template Error"),
)
def parse_data_from_template(self):
header = None
data = []
@ -500,6 +483,32 @@ class ImportFile:
title=_("Template Error"),
)
def validate_data_from_template_file(self, data):
mandatory_fields = self.get_mandatory_fields()
headers = data[0] if data else []
if not headers:
frappe.throw(_("Import template should contain a Header row."), title=_("Template Error"))
for field in mandatory_fields:
if field not in headers:
frappe.throw(
_(
"Mandatory field {0} is missing in the import template for {1}. Please correct the template and try again."
).format(frappe.bold(field), frappe.bold(self.doctype)),
title=_("Template Error"),
)
def get_mandatory_fields(self):
meta = frappe.get_meta(self.doctype)
mandatory_fields = []
for df in meta.fields:
if df.reqd and df.fieldtype not in no_value_fields:
mandatory_fields.append(df.label)
return mandatory_fields
def get_data_for_import_preview(self):
"""Adds a serial number column as the first column"""