diff --git a/frappe/desk/page/setup_wizard/setup_wizard.js b/frappe/desk/page/setup_wizard/setup_wizard.js
index c39e7f52c0..f44a57e339 100644
--- a/frappe/desk/page/setup_wizard/setup_wizard.js
+++ b/frappe/desk/page/setup_wizard/setup_wizard.js
@@ -201,7 +201,7 @@ frappe.setup.SetupWizard = class SetupWizard extends frappe.ui.Slides {
this.abort_setup(r.message.fail);
}
},
- error: this.abort_setup("Error in setup", true)
+ error: () => this.abort_setup("Error in setup")
});
}
diff --git a/frappe/public/build.json b/frappe/public/build.json
index 35e9d62436..f2a4d65582 100755
--- a/frappe/public/build.json
+++ b/frappe/public/build.json
@@ -194,7 +194,6 @@
"public/js/frappe/ui/toolbar/search.js",
"public/js/frappe/ui/toolbar/tag_utils.js",
"public/js/frappe/ui/toolbar/search.html",
- "public/js/frappe/ui/toolbar/search_header.html",
"public/js/frappe/ui/toolbar/search_utils.js",
"public/js/frappe/ui/toolbar/about.js",
"public/js/frappe/ui/toolbar/navbar.html",
diff --git a/frappe/public/icons/timeless/symbol-defs.svg b/frappe/public/icons/timeless/symbol-defs.svg
index c1e415fb46..ed02f91a46 100644
--- a/frappe/public/icons/timeless/symbol-defs.svg
+++ b/frappe/public/icons/timeless/symbol-defs.svg
@@ -677,6 +677,9 @@
+
+
+
diff --git a/frappe/public/js/frappe/form/controls/autocomplete.js b/frappe/public/js/frappe/form/controls/autocomplete.js
index ddde8ab2f7..27ebad24c3 100644
--- a/frappe/public/js/frappe/form/controls/autocomplete.js
+++ b/frappe/public/js/frappe/form/controls/autocomplete.js
@@ -89,18 +89,16 @@ frappe.ui.form.ControlAutocomplete = frappe.ui.form.ControlData.extend({
});
this.$input.on("awesomplete-open", () => {
- let modal = this.$input.parents('.modal-dialog')[0];
- if (modal) {
- $(modal).removeClass("modal-dialog-scrollable");
- }
+ this.toggle_container_scroll('.modal-dialog', 'modal-dialog-scrollable');
+ this.toggle_container_scroll('.grid-form-body .form-area', 'scrollable');
+
this.autocomplete_open = true;
});
this.$input.on("awesomplete-close", () => {
- let modal = this.$input.parents('.modal-dialog')[0];
- if (modal) {
- $(modal).addClass("modal-dialog-scrollable");
- }
+ this.toggle_container_scroll('.modal-dialog', 'modal-dialog-scrollable', true);
+ this.toggle_container_scroll('.grid-form-body .form-area', 'scrollable', true);
+
this.autocomplete_open = false;
});
diff --git a/frappe/public/js/frappe/form/controls/data.js b/frappe/public/js/frappe/form/controls/data.js
index 48b4d9da35..f381d1b4a2 100644
--- a/frappe/public/js/frappe/form/controls/data.js
+++ b/frappe/public/js/frappe/form/controls/data.js
@@ -129,5 +129,9 @@ frappe.ui.form.ControlData = frappe.ui.form.ControlInput.extend({
} else {
return v;
}
+ },
+ toggle_container_scroll: function(el_class, scroll_class, add=false) {
+ let el = this.$input.parents(el_class)[0];
+ if (el) $(el).toggleClass(scroll_class, add);
}
});
diff --git a/frappe/public/js/frappe/form/controls/link.js b/frappe/public/js/frappe/form/controls/link.js
index ce849097f7..670bb8b3e0 100644
--- a/frappe/public/js/frappe/form/controls/link.js
+++ b/frappe/public/js/frappe/form/controls/link.js
@@ -236,18 +236,16 @@ frappe.ui.form.ControlLink = frappe.ui.form.ControlData.extend({
});
this.$input.on("awesomplete-open", () => {
- let modal = this.$input.parents('.modal-dialog')[0];
- if (modal) {
- $(modal).removeClass("modal-dialog-scrollable");
- }
+ this.toggle_container_scroll('.modal-dialog', 'modal-dialog-scrollable');
+ this.toggle_container_scroll('.grid-form-body .form-area', 'scrollable');
+
this.autocomplete_open = true;
});
this.$input.on("awesomplete-close", () => {
- let modal = this.$input.parents('.modal-dialog')[0];
- if (modal) {
- $(modal).addClass("modal-dialog-scrollable");
- }
+ this.toggle_container_scroll('.modal-dialog', 'modal-dialog-scrollable', true);
+ this.toggle_container_scroll('.grid-form-body .form-area', 'scrollable', true);
+
this.autocomplete_open = false;
});
diff --git a/frappe/public/js/frappe/form/grid_row_form.js b/frappe/public/js/frappe/form/grid_row_form.js
index 399f233c54..68e4178ae7 100644
--- a/frappe/public/js/frappe/form/grid_row_form.js
+++ b/frappe/public/js/frappe/form/grid_row_form.js
@@ -66,7 +66,7 @@ export default class GridRowForm {