vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: onboarding - write in read only request (#34537)

Browse source 
* fix: remove read_only decorator from get_desktop_page
get_desktop_page leads to a call to check_completions which calls save and thus with the read_only decorator calls save on the read replica

* fix: Avoid changes to DB in read only request

* Revert "fix: remove read_only decorator from get_desktop_page"

This reverts commit 93db873bb707c6b58c7e6e68499df173aaa66d49.

---------

Co-authored-by: Apile Tyumre <apiletyumre@iridescentsun.com>
This commit is contained in:
Ankush Menat 2025-10-30 11:32:36 +05:30 • committed by GitHub
parent 6d2ca3913c
commit bf58e7be1f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frappe/desk/doctype/module_onboarding/module_onboarding.py
View file

@ -53,11 +53,15 @@ class ModuleOnboarding(Document):
is_complete = [bool(step.is_complete or step.is_skipped) for step in steps]
if all(is_complete):
self.is_complete = True
self.save(ignore_permissions=True)
frappe.enqueue(self.mark_as_completed, enqueue_after_commit=True)
return True
return False
def mark_as_completed(self):
self.is_complete = True
self.save(ignore_permissions=True)
@frappe.whitelist()
def reset_progress(self):
self.db_set("is_complete", 0)