From c1ab5b8479fc9d881c761c3a0987ab1ff1dbbf40 Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Tue, 9 Mar 2021 11:48:24 +0530 Subject: [PATCH] fix: Section collapse in modal (#12536) Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> --- frappe/public/js/frappe/form/layout.js | 2 +- frappe/public/js/frappe/ui/dialog.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/layout.js b/frappe/public/js/frappe/form/layout.js index aad3740ab0..d3480b1b75 100644 --- a/frappe/public/js/frappe/form/layout.js +++ b/frappe/public/js/frappe/form/layout.js @@ -289,7 +289,7 @@ frappe.ui.form.Layout = Class.extend({ }, refresh_section_collapse: function () { - if (!this.doc) return; + if (!(this.sections && this.sections.length)) return; for (var i = 0; i < this.sections.length; i++) { var section = this.sections[i]; diff --git a/frappe/public/js/frappe/ui/dialog.js b/frappe/public/js/frappe/ui/dialog.js index 59836fae23..6761d1d326 100644 --- a/frappe/public/js/frappe/ui/dialog.js +++ b/frappe/public/js/frappe/ui/dialog.js @@ -52,6 +52,8 @@ frappe.ui.Dialog = class Dialog extends frappe.ui.FieldGroup { // make fields (if any) super.make(); + this.refresh_section_collapse(); + // show footer this.action = this.action || { primary: { }, secondary: { } }; if (this.primary_action || (this.action.primary && this.action.primary.onsubmit)) {