From c1d687ddbb85c1ba2ceaa8ad0f23434ed9aa5308 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 8 Jan 2024 12:42:13 +0530 Subject: [PATCH] fix: ignore user settings on report doc (#24162) --- frappe/public/js/frappe/views/reports/report_view.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/views/reports/report_view.js b/frappe/public/js/frappe/views/reports/report_view.js index 10f3143dac..ad9ce770f7 100644 --- a/frappe/public/js/frappe/views/reports/report_view.js +++ b/frappe/public/js/frappe/views/reports/report_view.js @@ -111,10 +111,9 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView { //Setup groupby for reports this.group_by_control = new frappe.ui.GroupBy(this); - if (this.report_doc && this.report_doc.json.group_by) { + if (this.report_doc?.json?.group_by) { this.group_by_control.apply_settings(this.report_doc.json.group_by); - } - if (this.view_user_settings && this.view_user_settings.group_by) { + } else if (this.view_user_settings?.group_by) { this.group_by_control.apply_settings(this.view_user_settings.group_by); } }