From c1dddc17dacd341ee36a871ba76be9cd776f5f0a Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Thu, 26 Sep 2019 19:36:11 +0530 Subject: [PATCH] Revert "refactor: Remove redundant code" This reverts commit 2773313dcbca7f3071000df77fa603121a7c9ea2. Because the changes would have resulted in other test failure... not worth it. --- frappe/tests/ui_test_helpers.py | 38 ++++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/frappe/tests/ui_test_helpers.py b/frappe/tests/ui_test_helpers.py index 4b5a854eb9..aaed05ca3a 100644 --- a/frappe/tests/ui_test_helpers.py +++ b/frappe/tests/ui_test_helpers.py @@ -33,19 +33,33 @@ def create_if_not_exists(doc): @frappe.whitelist() def create_todo_records(): - frappe.db.sql("DELETE FROM `tabToDo` WHERE name!=''") - - for number in range(1, 5): - frappe.get_doc({ - "doctype": "ToDo", - "date": add_to_date(now(), days=3), - "description": "this is {} todo".format(number) - }).insert() + if frappe.db.get_all('ToDo', {'description': 'this is first todo'}): + return + frappe.get_doc({ + "doctype": "ToDo", + "date": add_to_date(now(), days=3), + "description": "this is first todo" + }).insert() + frappe.get_doc({ + "doctype": "ToDo", + "date": add_to_date(now(), days=-3), + "description": "this is second todo" + }).insert() + frappe.get_doc({ + "doctype": "ToDo", + "date": add_to_date(now(), months=2), + "description": "this is third todo" + }).insert() + frappe.get_doc({ + "doctype": "ToDo", + "date": add_to_date(now(), months=-2), + "description": "this is fourth todo" + }).insert() @frappe.whitelist() def setup_workflow(): - from frappe.workflow.doctype.workflow.test_workflow import create_todo_workflow - create_todo_workflow() - create_todo_records() - frappe.clear_cache() + from frappe.workflow.doctype.workflow.test_workflow import create_todo_workflow + create_todo_workflow() + create_todo_records() + frappe.clear_cache()