From c2a5adadbe4176a18d539efffec75104d5601b53 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 19 Jul 2023 20:42:43 +0530 Subject: [PATCH] fix: actually debounce list view updates (#21738) Immediately debouncing and executing creates a new function everytime and doesn't actually "debounce" it just "delays". :moyai: [skip ci] --- frappe/public/js/frappe/list/list_view.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index f3af9bd1be..d69a46d16b 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -24,6 +24,10 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { constructor(opts) { super(opts); this.show(); + this.debounced_refresh = frappe.utils.debounce( + this.process_document_refreshes.bind(this), + 2000 + ); } has_permissions() { @@ -1377,7 +1381,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { } this.pending_document_refreshes.push(data); - frappe.utils.debounce(this.process_document_refreshes.bind(this), 1000)(); + this.debounced_refresh(); }); this.realtime_events_setup = true; }