vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(query): handle string argument with between

Browse source 
Prevents crash when filter value doesn't exist (example, invalid Fiscal Year)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2026-01-08 16:34:27 +05:30
parent fb07cf7579
commit c2e2ca611a
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frappe/database/query.py
View file

@ -567,8 +567,17 @@ class Engine:
_value = _apply_date_field_filter_conversion(_value, _operator, doctype or self.doctype, field)
# For Datetime fields with date values and 'between' operator, convert to datetime range to match db_query
if _operator.lower() == "between" and isinstance(_value, list | tuple) and len(_value) == 2:
_value = _apply_datetime_field_filter_conversion(_value, doctype or self.doctype, field)
if _operator.lower() == "between":
if isinstance(_value, list | tuple) and len(_value) == 2:
_value = _apply_datetime_field_filter_conversion(_value, doctype or self.doctype, field)
elif isinstance(_value, str):
from frappe.model.db_query import get_between_date_filter
target_meta = frappe.get_meta(doctype or self.doctype)
df = target_meta.get_field(field)
_value = tuple(
v.strip().strip("'") for v in get_between_date_filter(_value, df).split(" AND ")
)
if not _value and isinstance(_value, list | tuple | set):
_value = ("",)