From c45fbce2faf5bdcb86ad0f96f59dfbbc61082134 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 26 Jul 2023 09:23:06 +0530 Subject: [PATCH] fix: ignore no args to email read url Some client can strip this and it will cause error. --- frappe/email/doctype/newsletter/newsletter.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/email/doctype/newsletter/newsletter.py b/frappe/email/doctype/newsletter/newsletter.py index 554ea79b08..09200e3635 100644 --- a/frappe/email/doctype/newsletter/newsletter.py +++ b/frappe/email/doctype/newsletter/newsletter.py @@ -411,7 +411,9 @@ def send_scheduled_email(): @frappe.whitelist(allow_guest=True) -def newsletter_email_read(recipient_email, reference_doctype, reference_name): +def newsletter_email_read(recipient_email=None, reference_doctype=None, reference_name=None): + if not (recipient_email and reference_name): + return verify_request() try: doc = frappe.get_cached_doc("Newsletter", reference_name)