From c4c151ed9bdcfe393175e2cd421a21543372fdf7 Mon Sep 17 00:00:00 2001 From: Rahul Agrawal <12agrawalrahul@gmail.com> Date: Wed, 3 Sep 2025 10:57:37 +0530 Subject: [PATCH] chore: update field name --- frappe/core/doctype/system_settings/system_settings.json | 8 ++++---- frappe/core/doctype/system_settings/system_settings.py | 2 +- frappe/core/doctype/user/user.py | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/frappe/core/doctype/system_settings/system_settings.json b/frappe/core/doctype/system_settings/system_settings.json index 43e9b29389..3622b79def 100644 --- a/frappe/core/doctype/system_settings/system_settings.json +++ b/frappe/core/doctype/system_settings/system_settings.json @@ -37,7 +37,7 @@ "column_break_txqh", "deny_multiple_sessions", "disable_user_pass_login", - "max_signups_per_hour", + "max_signups_allowed_per_hour", "login_methods_section", "allow_login_using_mobile_number", "allow_login_using_user_name", @@ -731,16 +731,16 @@ }, { "default": "300", - "fieldname": "max_signups_per_hour", + "fieldname": "max_signups_allowed_per_hour", "fieldtype": "Int", - "label": "Max Signups Per Hour", + "label": "Max signups allowed per hour", "non_negative": 1 } ], "icon": "fa fa-cog", "issingle": 1, "links": [], - "modified": "2025-09-03 10:23:09.830755", + "modified": "2025-09-03 10:52:38.096662", "modified_by": "Administrator", "module": "Core", "name": "System Settings", diff --git a/frappe/core/doctype/system_settings/system_settings.py b/frappe/core/doctype/system_settings/system_settings.py index 12e5cb999e..79de257142 100644 --- a/frappe/core/doctype/system_settings/system_settings.py +++ b/frappe/core/doctype/system_settings/system_settings.py @@ -73,7 +73,7 @@ class SystemSettings(Document): max_auto_email_report_per_user: DF.Int max_file_size: DF.Int max_report_rows: DF.Int - max_signups_per_hour: DF.Int + max_signups_allowed_per_hour: DF.Int minimum_password_score: DF.Literal["1", "2", "3", "4"] number_format: DF.Literal[ "#,###.##", diff --git a/frappe/core/doctype/user/user.py b/frappe/core/doctype/user/user.py index d0a6d3517a..02ede19efe 100644 --- a/frappe/core/doctype/user/user.py +++ b/frappe/core/doctype/user/user.py @@ -1035,8 +1035,8 @@ def sign_up(email: str, full_name: str, redirect_to: str) -> tuple[int, str]: else: return 0, _("Registered but disabled") else: - max_signups_per_hour = cint(frappe.get_system_settings("max_signups_per_hour") or 300) - if frappe.db.get_creation_count("User", 60) > max_signups_per_hour: + max_signups_allowed_per_hour = cint(frappe.get_system_settings("max_signups_allowed_per_hour") or 300) + if frappe.db.get_creation_count("User", 60) > max_signups_allowed_per_hour: frappe.respond_as_web_page( _("Temporarily Disabled"), _(