From c4e8482da080304b45cd5edb61c3163adc97f7e6 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Mon, 28 May 2018 18:09:32 +0530 Subject: [PATCH] fix: get_contact_list in Email dialog (#5623) --- frappe/public/js/frappe/views/communication.js | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/frappe/public/js/frappe/views/communication.js b/frappe/public/js/frappe/views/communication.js index 372b4ada9d..6096540eba 100755 --- a/frappe/public/js/frappe/views/communication.js +++ b/frappe/public/js/frappe/views/communication.js @@ -21,6 +21,16 @@ frappe.views.CommunicationComposer = Class.extend({ } }); + frappe.call({ + method: "frappe.email.get_contact_list", + callback: (r) => { + const contactList = r.message; + ['recipients', 'cc', 'bcc'].forEach(field => { + this.dialog.fields_dict[field].set_data(contactList); + }); + } + }); + $(document).on("upload_complete", function(event, attachment) { if(me.dialog.display) { var wrapper = $(me.dialog.fields_dict.select_attachments.wrapper); @@ -47,13 +57,6 @@ frappe.views.CommunicationComposer = Class.extend({ get_fields: function() { let contactList = []; - frappe.call({ - method: "frappe.email.get_contact_list", - async: false, - callback: function(r) { - contactList = r.message; - } - }); var fields= [ {label:__("To"), fieldtype:"MultiSelect", reqd: 0, fieldname:"recipients",options:contactList}, {fieldtype: "Section Break", collapsible: 1, label: __("CC, BCC & Email Template")},