From c6d3f73ab5b65db7ff4e7a8d335dd6a440d94155 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Mon, 15 Jul 2019 19:44:23 +0530 Subject: [PATCH] refactor: remove filter returns a promise --- frappe/public/js/frappe/list/base_list.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js index 9141bcc525..2769d70433 100644 --- a/frappe/public/js/frappe/list/base_list.js +++ b/frappe/public/js/frappe/list/base_list.js @@ -551,12 +551,12 @@ class FilterArea { const fields_dict = this.list_view.page.fields_dict; if (fieldname in fields_dict) { - fields_dict[fieldname].set_value(''); - return; + return fields_dict[fieldname].set_value(''); } let filter = this.filter_list.get_filter(fieldname); if (filter) filter.remove(); + return Promise.resolve(); } clear(refresh = true) {