From c8ea0a72d08a591888ee8bc2a4f2a68023a017be Mon Sep 17 00:00:00 2001 From: phot0n Date: Wed, 23 Nov 2022 00:18:54 +0530 Subject: [PATCH] fix: render filters on refresh onload hook gave inconsistent behaviour --- frappe/core/doctype/prepared_report/prepared_report.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/prepared_report/prepared_report.js b/frappe/core/doctype/prepared_report/prepared_report.js index 7a0053b319..11f9caf8fd 100644 --- a/frappe/core/doctype/prepared_report/prepared_report.js +++ b/frappe/core/doctype/prepared_report/prepared_report.js @@ -2,7 +2,7 @@ // For license information, please see license.txt frappe.ui.form.on("Prepared Report", { - onload: function (frm) { + render_filter_values: function (frm) { var wrapper = $(frm.fields_dict["filter_values"].wrapper).empty(); let filter_table = $(` @@ -31,6 +31,7 @@ frappe.ui.form.on("Prepared Report", { refresh: function (frm) { frm.disable_save(); + frm.events.render_filter_values(frm); // always keep report_name hidden - we do this as we can't set mandatory and hidden // property on a docfield at the same time