From aabf641f412f92df2dc96869154a9d08a6e38820 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Sun, 7 Dec 2025 20:54:30 +0530
Subject: [PATCH 01/14] feat: new navbar design

---
 .../public/js/frappe/ui/toolbar/navbar.html   | 29 -------------------
 frappe/public/js/frappe/ui/toolbar/toolbar.js |  2 --
 2 files changed, 31 deletions(-)

diff --git a/frappe/public/js/frappe/ui/toolbar/navbar.html b/frappe/public/js/frappe/ui/toolbar/navbar.html
index 9879e4d17d..52941a9654 100644
--- a/frappe/public/js/frappe/ui/toolbar/navbar.html
+++ b/frappe/public/js/frappe/ui/toolbar/navbar.html
@@ -23,35 +23,6 @@
 					</div>
 					</div>
 				{% endif %}
-				<ul class="navbar-nav">
-					<li class="nav-item dropdown dropdown-navbar-user dropdown-mobile">
-						<button
-							class="btn-reset nav-link"
-							data-toggle="dropdown"
-							aria-label="{{ __("User Menu") }}"
-						>
-							{{ avatar }}
-						</button>
-						<div class="dropdown-menu dropdown-menu-right" id="toolbar-user" role="menu">
-							{% for item in navbar_settings.settings_dropdown %}
-								{% var condition = item.condition ? eval(item.condition) : true %}
-								{% if (condition && !item.hidden) { %}
-									{% if (item.route) { %}
-										<a class="dropdown-item" href="{{ item.route }}">
-											{%= __(item.item_label) %}
-										</a>
-									{% } else if (item.action) { %}
-										<button class="btn-reset dropdown-item" onclick="return {{ item.action }}">
-											{%= __(item.item_label) %}
-										</button>
-									{% } else { %}
-										<div class="dropdown-divider"></div>
-									{% } %}
-								{% } %}
-							{% endfor %}
-						</div>
-					</li>
-				</ul>
 			</div>
 		</div>
 	</header>
diff --git a/frappe/public/js/frappe/ui/toolbar/toolbar.js b/frappe/public/js/frappe/ui/toolbar/toolbar.js
index 0b7e171309..6cd070b4a1 100644
--- a/frappe/public/js/frappe/ui/toolbar/toolbar.js
+++ b/frappe/public/js/frappe/ui/toolbar/toolbar.js
@@ -8,7 +8,6 @@ frappe.ui.toolbar.Toolbar = class {
 	constructor() {
 		$("header").replaceWith(
 			frappe.render_template("navbar", {
-				avatar: frappe.avatar(frappe.session.user, "avatar-medium"),
 				navbar_settings: frappe.boot.navbar_settings,
 			})
 		);
@@ -17,7 +16,6 @@ frappe.ui.toolbar.Toolbar = class {
 			$(this).closest(".dropdown-menu").prev().dropdown("toggle");
 		});
 
-		// this.setup_awesomebar();
 		this.setup_read_only_mode();
 		this.setup_announcement_widget();
 		this.make();

From 55a29e818b31213fb3561279315462991777a94e Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Sun, 7 Dec 2025 23:30:05 +0530
Subject: [PATCH 02/14] refactor: add readonly and imporsinote indicator back

---
 frappe/public/js/frappe/ui/toolbar/navbar.html | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/frappe/public/js/frappe/ui/toolbar/navbar.html b/frappe/public/js/frappe/ui/toolbar/navbar.html
index 52941a9654..6859c94616 100644
--- a/frappe/public/js/frappe/ui/toolbar/navbar.html
+++ b/frappe/public/js/frappe/ui/toolbar/navbar.html
@@ -10,6 +10,16 @@
 			</a>
 			<ul class="nav navbar-nav d-none d-sm-flex" id="navbar-breadcrumbs"></ul>
 			<div class="collapse navbar-collapse justify-content-end">
+				{% if (frappe.boot.read_only) { %}
+					<span class="indicator-pill yellow no-indicator-dot read-only-banner" title="{%= __("Your site is undergoing maintenance or being updated.") %}">
+						{%= __("Read Only Mode") %}
+					</span>
+				{% } %}
+				{% if (frappe.boot.user.impersonated_by) { %}
+					<span class="indicator-pill red no-indicator-dot" title="{%= __("You are impersonating as another user.") %}">
+						{%= __("Impersonating {0}", [frappe.boot.user.name]) %}
+					</span>
+				{% } %}
 				{% if frappe.is_mobile() %}
 					<div class="search-bar text-muted hidden">
 						<div

From 727446ab3b24364c9bf4a48407a2e62a4496186b Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 12:58:56 +0530
Subject: [PATCH 03/14] feat: design navbar of mobile view

---
 frappe/public/js/frappe/form/layout.js        |  4 ++-
 frappe/public/js/frappe/ui/page.html          | 25 +++-------------
 frappe/public/js/frappe/ui/page.js            |  8 +++--
 .../public/js/frappe/ui/toolbar/navbar.html   | 26 +++++++++-------
 frappe/public/js/frappe/ui/toolbar/toolbar.js | 30 +++++++++----------
 frappe/public/js/frappe/views/breadcrumbs.js  |  7 ++---
 frappe/public/scss/desk/breadcrumb.scss       |  8 ++++-
 frappe/public/scss/desk/form.scss             |  5 +++-
 frappe/public/scss/desk/mobile.scss           | 13 ++++----
 frappe/public/scss/desk/page.scss             |  5 +++-
 10 files changed, 67 insertions(+), 64 deletions(-)

diff --git a/frappe/public/js/frappe/form/layout.js b/frappe/public/js/frappe/form/layout.js
index 8f8b1da1fc..9a94868701 100644
--- a/frappe/public/js/frappe/form/layout.js
+++ b/frappe/public/js/frappe/form/layout.js
@@ -549,7 +549,9 @@ frappe.ui.form.Layout = class Layout {
 			if (tabs_content.getBoundingClientRect().top < 100) {
 				tabs_content.scrollIntoView();
 				setTimeout(() => {
-					$(".page-head").css("top", "-15px");
+					if (frappe.boot.read_only || frappe.boot.user.impersonated_by) {
+						$(".page-head").css("top", "-15px");
+					}
 					$(".form-tabs-list").removeClass("form-tabs-sticky-down");
 					$(".form-tabs-list").addClass("form-tabs-sticky-up");
 				}, 3);
diff --git a/frappe/public/js/frappe/ui/page.html b/frappe/public/js/frappe/ui/page.html
index 7bc39be3d2..d0e5f8c12d 100644
--- a/frappe/public/js/frappe/ui/page.html
+++ b/frappe/public/js/frappe/ui/page.html
@@ -1,28 +1,11 @@
-<div class="page-head flex">
+<div class="page-head flex {% if frappe.boot.read_only || frappe.boot.user.impersonated_by %}show-navbar{% endif %}">
 	<div class="container">
 		<div class="row flex-nowrap align-center page-head-content justify-between">
 			<div class="col-md-4 col-sm-6 col-xs-7 page-title">
-				<!-- <div class="title-image hide hidden-md hidden-lg"></div> -->
-				<!-- title -->
-				<button class="btn-reset sidebar-toggle-btn">
-					<svg class="es-icon icon-md sidebar-toggle-placeholder">
-						<use href="#es-line-align-justify"></use>
-					</svg>
-					<span class="sidebar-toggle-icon">
-						<svg class="es-icon icon-md">
-							<use href="#es-line-sidebar-collapse">
-							</use>
-						</svg>
-					</span>
-				</button>
 				<div class="flex fill-width title-area">
-					<div>
-						<div class="flex">
-							<h3 class="ellipsis title-text"></h3>
-							<span class="indicator-pill whitespace-nowrap"></span>
-						</div>
-						<div class="ellipsis sub-heading hide text-muted"></div>
-					</div>
+					{% if (!frappe.is_mobile()) { %}
+						<ul class="nav d-sm-flex navbar-breadcrumbs"></ul>
+					{% endif %}
 					<button class="btn btn-default more-button hide">
 						<svg class="icon icon-sm">
 							<use href="#icon-dot-horizontal">
diff --git a/frappe/public/js/frappe/ui/page.js b/frappe/public/js/frappe/ui/page.js
index ed0225a35b..857bbcb4dd 100644
--- a/frappe/public/js/frappe/ui/page.js
+++ b/frappe/public/js/frappe/ui/page.js
@@ -53,9 +53,13 @@ frappe.ui.Page = class Page {
 			frappe.utils.throttle(() => {
 				$(".page-head").toggleClass("drop-shadow", !!document.documentElement.scrollTop);
 				let current_scroll = document.documentElement.scrollTop;
-				if (current_scroll > 0 && last_scroll <= current_scroll) {
+				if (
+					current_scroll > 0 &&
+					last_scroll <= current_scroll &&
+					(frappe.boot.read_only || frappe.boot.user.impersonated_by)
+				) {
 					$(".page-head").css("top", "-15px");
-				} else {
+				} else if (frappe.boot.read_only || frappe.boot.user.impersonated_by) {
 					$(".page-head").css("top", "var(--navbar-height)");
 				}
 				last_scroll = current_scroll;
diff --git a/frappe/public/js/frappe/ui/toolbar/navbar.html b/frappe/public/js/frappe/ui/toolbar/navbar.html
index 6859c94616..f5f91d4499 100644
--- a/frappe/public/js/frappe/ui/toolbar/navbar.html
+++ b/frappe/public/js/frappe/ui/toolbar/navbar.html
@@ -1,14 +1,17 @@
 <div class="sticky-top">
+	{% if (frappe.boot.read_only || frappe.boot.user.impersonated_by || frappe.is_mobile()) { %}
 	<header class="navbar navbar-expand" role="navigation">
 		<div class="container">
-			<a class="navbar-brand navbar-home" href="/desk">
-				<img
-					class="app-logo"
-					src="{{ frappe.boot.app_data[0].app_logo_url }}"
-					alt="{{ __("App Logo") }}"
-				>
+			<a class="navbar-brand navbar-home">
+				<span class="app-logo">
+					<svg class="es-icon icon-md">
+						<use href="#es-line-align-justify"></use>
+					</svg>
+				</span>
 			</a>
-			<ul class="nav navbar-nav d-none d-sm-flex" id="navbar-breadcrumbs"></ul>
+			{% if (frappe.is_mobile()) { %}
+				<ul class="nav d-sm-flex navbar-breadcrumbs mobile-no-divider"></ul>
+			{% endif %}
 			<div class="collapse navbar-collapse justify-content-end">
 				{% if (frappe.boot.read_only) { %}
 					<span class="indicator-pill yellow no-indicator-dot read-only-banner" title="{%= __("Your site is undergoing maintenance or being updated.") %}">
@@ -27,15 +30,16 @@
 							class="navbar-modal-search-mobile"
 							placeholder="Search for type a command"
 						>
-						<span class="search-icon">
-							<svg class="icon icon-sm"><use href="#icon-search"></use></svg>
-						</span>
-					</div>
+							<span class="search-icon">
+								<svg class="icon icon-sm"><use href="#icon-search"></use></svg>
+							</span>
+						</div>
 					</div>
 				{% endif %}
 			</div>
 		</div>
 	</header>
+	{% endif %}
 
 	{% if !localStorage.getItem("dismissed_announcement_widget") && strip_html(navbar_settings.announcement_widget) != '' %}
 	<div class="announcement-widget form-message p-2 m-0" style="position: relative; z-index: -1; border-radius: 0; background-color: var(--bg-blue);">
diff --git a/frappe/public/js/frappe/ui/toolbar/toolbar.js b/frappe/public/js/frappe/ui/toolbar/toolbar.js
index 6cd070b4a1..6d1d5a5649 100644
--- a/frappe/public/js/frappe/ui/toolbar/toolbar.js
+++ b/frappe/public/js/frappe/ui/toolbar/toolbar.js
@@ -6,11 +6,19 @@ frappe.provide("frappe.search");
 
 frappe.ui.toolbar.Toolbar = class {
 	constructor() {
-		$("header").replaceWith(
-			frappe.render_template("navbar", {
-				navbar_settings: frappe.boot.navbar_settings,
-			})
-		);
+		if (
+			frappe.boot.read_only ||
+			frappe.boot.user.impersonated_by ||
+			(!localStorage.getItem("dismissed_announcement_widget") &&
+				strip_html(frappe.boot.navbar_settings.announcement_widget) != "") ||
+			frappe.is_mobile()
+		) {
+			$("header").replaceWith(
+				frappe.render_template("navbar", {
+					navbar_settings: frappe.boot.navbar_settings,
+				})
+			);
+		}
 		$(".dropdown-toggle").dropdown();
 		$("#toolbar-user a[href]").click(function () {
 			$(this).closest(".dropdown-menu").prev().dropdown("toggle");
@@ -31,9 +39,7 @@ frappe.ui.toolbar.Toolbar = class {
 	change_toolbar() {
 		$(".navbar .container").css("max-width", "43%");
 		$(".navbar-brand").css("display", "block");
-		$(".navbar-brand .app-logo").attr("src", frappe.boot.navbar_settings.app_logo);
 		let nav_elements = $(".navbar-nav").children();
-		$("form").css("display", "none");
 		$("");
 		for (let i = 0; i < nav_elements.length - 1; i++) {
 			$(nav_elements[i]).attr("style", "display: none !important");
@@ -110,18 +116,10 @@ frappe.ui.toolbar.Toolbar = class {
 	}
 	show_app_logo() {
 		let route = frappe.get_route();
-		if (route[0] == "List") {
-			this.navbar.html("");
-			this.navbar.html(this.app_logo);
-			this.navbar.attr("href", "");
-			this.bind_click();
-		} else if (route[0] == "Form") {
+		if (route[0] == "Form") {
 			this.add_back_button();
 		}
 	}
-	set_app_logo(logo_url) {
-		$(".navbar-brand .app-logo").attr("src", logo_url);
-	}
 };
 
 $.extend(frappe.ui.toolbar, {
diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js
index f15c57b9a4..04bb29b39c 100644
--- a/frappe/public/js/frappe/views/breadcrumbs.js
+++ b/frappe/public/js/frappe/views/breadcrumbs.js
@@ -67,9 +67,10 @@ frappe.breadcrumbs = {
 				this.set_list_breadcrumb(breadcrumbs);
 				this.set_form_breadcrumb(breadcrumbs, view);
 			} else if (breadcrumbs.doctype && view === "list") {
-				// pass
+				this.set_list_breadcrumb(breadcrumbs);
 			} else if (breadcrumbs.doctype && view == "dashboard-view") {
 				this.set_list_breadcrumb(breadcrumbs);
+				this.set_dashboard_breadcrumb(breadcrumbs);
 			}
 		}
 
@@ -198,8 +199,6 @@ frappe.breadcrumbs = {
 
 		let title = frappe.model.get_doc_title(doc);
 
-		if (title == doc.name) return; // title and name are same, don't add breadcrumb
-
 		let form_route = `/desk/${frappe.router.slug(doctype)}/${encodeURIComponent(docname)}`;
 		this.append_breadcrumb_element(form_route, doc.name);
 
@@ -238,7 +237,7 @@ frappe.breadcrumbs = {
 	},
 
 	clear() {
-		this.$breadcrumbs = $("#navbar-breadcrumbs").empty();
+		this.$breadcrumbs = $(".navbar-breadcrumbs").empty();
 	},
 
 	toggle(show) {
diff --git a/frappe/public/scss/desk/breadcrumb.scss b/frappe/public/scss/desk/breadcrumb.scss
index 1751befa7e..813d6f8c7b 100644
--- a/frappe/public/scss/desk/breadcrumb.scss
+++ b/frappe/public/scss/desk/breadcrumb.scss
@@ -4,7 +4,7 @@
 	background-color: white;
 }
 /*! This comment will be included even in compressed mode. */
-#navbar-breadcrumbs {
+.navbar-breadcrumbs {
 	a {
 		font-size: var(--text-lg);
 		text-decoration: none;
@@ -28,6 +28,12 @@
 		}
 	}
 
+	&.mobile-no-divider {
+		a:before {
+			content: "";
+		}
+	}
+
 	li:first-child a:before {
 		// no angle before first item
 		content: none;
diff --git a/frappe/public/scss/desk/form.scss b/frappe/public/scss/desk/form.scss
index 776950ad10..677c20316f 100644
--- a/frappe/public/scss/desk/form.scss
+++ b/frappe/public/scss/desk/form.scss
@@ -512,7 +512,10 @@
 	top: calc(var(--navbar-height) - 1px);
 }
 .form-tabs-sticky-down {
-	top: calc(var(--navbar-height) + var(--page-head-height) - 1px);
+	top: calc(var(--navbar-height) - 2px);
+	&.show-navbar {
+		top: calc(var(--navbar-height) + var(--page-head-height) - 1px);
+	}
 }
 
 .progress-area {
diff --git a/frappe/public/scss/desk/mobile.scss b/frappe/public/scss/desk/mobile.scss
index a9cbf23191..0c890f04aa 100644
--- a/frappe/public/scss/desk/mobile.scss
+++ b/frappe/public/scss/desk/mobile.scss
@@ -64,9 +64,10 @@ body {
 		}
 	}
 
-	#navbar-breadcrumbs {
+	.navbar-breadcrumbs {
 		display: inline-block;
-		max-width: 150px;
+		max-width: 200px;
+		width: 100%;
 		overflow: hidden;
 		white-space: nowrap;
 		text-overflow: ellipsis;
@@ -78,18 +79,18 @@ body {
 		}
 	}
 
-	#navbar-breadcrumbs > li,
-	#navbar-breadcrumbs > li > a {
+	.navbar-breadcrumbs > li,
+	.navbar-breadcrumbs > li > a {
 		display: inline-block;
 		vertical-align: middle;
 	}
 
-	#navbar-breadcrumbs > li > a:before {
+	.navbar-breadcrumbs > li > a:before {
 		// .breadcrumb-divider-left();
 	}
 
 	// select all except last 2
-	#navbar-breadcrumbs li:not(:nth-last-child(-n + 1)) {
+	.navbar-breadcrumbs li:not(:nth-last-child(-n + 1)) {
 		display: none;
 	}
 
diff --git a/frappe/public/scss/desk/page.scss b/frappe/public/scss/desk/page.scss
index 169dafd6ad..122cfb8035 100644
--- a/frappe/public/scss/desk/page.scss
+++ b/frappe/public/scss/desk/page.scss
@@ -107,10 +107,13 @@
 .page-head {
 	z-index: 6;
 	position: sticky;
-	top: var(--navbar-height);
 	background: var(--bg-color);
 	border-bottom: 1px solid var(--border-color);
 	transition: 0.5s top;
+	top: 0;
+	&.show-navbar {
+		top: var(--navbar-height);
+	}
 
 	.page-head-content {
 		height: var(--page-head-height);

From a27cb7e14817b7f3950425da5f1bb586e0fd1445 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 14:40:03 +0530
Subject: [PATCH 04/14] feat: show new doc name on breadcrumb

---
 frappe/public/js/frappe/views/breadcrumbs.js | 26 ++++++++++++++------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js
index 04bb29b39c..549d04d3f6 100644
--- a/frappe/public/js/frappe/views/breadcrumbs.js
+++ b/frappe/public/js/frappe/views/breadcrumbs.js
@@ -81,11 +81,18 @@ frappe.breadcrumbs = {
 		this.append_breadcrumb_element(breadcrumbs.route, breadcrumbs.label);
 	},
 
-	append_breadcrumb_element(route, label) {
+	append_breadcrumb_element(route, label, is_new_doc = false) {
 		const el = document.createElement("li");
 		const a = document.createElement("a");
 		a.href = route;
-		a.innerText = label;
+		if (is_new_doc) {
+			const small_tag = document.createElement("small");
+			small_tag.classList.add("text-muted");
+			small_tag.innerText = label;
+			a.appendChild(small_tag);
+		} else {
+			a.innerText = label;
+		}
 		el.appendChild(a);
 		this.$breadcrumbs.append(el);
 	},
@@ -194,13 +201,16 @@ frappe.breadcrumbs = {
 		const doctype = breadcrumbs.doctype;
 		let docname = frappe.get_route().slice(2).join("/");
 		let doc = frappe.get_doc(doctype, docname);
-
-		if (doc.__islocal) return; // new doc, no breadcrumb required
-
-		let title = frappe.model.get_doc_title(doc);
-
 		let form_route = `/desk/${frappe.router.slug(doctype)}/${encodeURIComponent(docname)}`;
-		this.append_breadcrumb_element(form_route, doc.name);
+
+		let docname_title;
+		if (docname.startsWith("new-" + doctype.toLowerCase().replace(/ /g, "-"))) {
+			docname_title = __("New {0}", [__(doctype)]);
+			this.append_breadcrumb_element(form_route, docname_title, true);
+		} else {
+			docname_title = doc.name;
+			this.append_breadcrumb_element(form_route, docname_title);
+		}
 
 		if (view === "form") {
 			let last_crumb = this.$breadcrumbs.find("li").last();

From 4758119b069ff4e7629bafbfc4f1e3ff70ce0c70 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 14:44:27 +0530
Subject: [PATCH 05/14] fix: add indicator back

---
 frappe/public/js/frappe/ui/page.html | 1 +
 frappe/public/scss/desk/page.scss    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/frappe/public/js/frappe/ui/page.html b/frappe/public/js/frappe/ui/page.html
index d0e5f8c12d..a0d11d4e38 100644
--- a/frappe/public/js/frappe/ui/page.html
+++ b/frappe/public/js/frappe/ui/page.html
@@ -6,6 +6,7 @@
 					{% if (!frappe.is_mobile()) { %}
 						<ul class="nav d-sm-flex navbar-breadcrumbs"></ul>
 					{% endif %}
+					<span class="indicator-pill whitespace-nowrap"></span>
 					<button class="btn btn-default more-button hide">
 						<svg class="icon icon-sm">
 							<use href="#icon-dot-horizontal">
diff --git a/frappe/public/scss/desk/page.scss b/frappe/public/scss/desk/page.scss
index 122cfb8035..e96eb04306 100644
--- a/frappe/public/scss/desk/page.scss
+++ b/frappe/public/scss/desk/page.scss
@@ -44,6 +44,7 @@
 		}
 		.indicator-pill {
 			margin-top: 2px;
+			margin-left: var(--margin-sm);
 		}
 		.sub-heading {
 			@include get_textstyle("sm", "regular");

From 763e92bda06d462c0ad7f1620338cdd1e75a7039 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 14:46:04 +0530
Subject: [PATCH 06/14] fix: increase breadcrumb width

---
 frappe/public/js/frappe/ui/page.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frappe/public/js/frappe/ui/page.html b/frappe/public/js/frappe/ui/page.html
index a0d11d4e38..12e63a576b 100644
--- a/frappe/public/js/frappe/ui/page.html
+++ b/frappe/public/js/frappe/ui/page.html
@@ -1,7 +1,7 @@
 <div class="page-head flex {% if frappe.boot.read_only || frappe.boot.user.impersonated_by %}show-navbar{% endif %}">
 	<div class="container">
 		<div class="row flex-nowrap align-center page-head-content justify-between">
-			<div class="col-md-4 col-sm-6 col-xs-7 page-title">
+			<div class="col-md-6 col-sm-6 col-xs-7 page-title">
 				<div class="flex fill-width title-area">
 					{% if (!frappe.is_mobile()) { %}
 						<ul class="nav d-sm-flex navbar-breadcrumbs"></ul>

From 6a45fde1343fad087271c2e0c9b195ecc33499dc Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 16:13:31 +0530
Subject: [PATCH 07/14] feat: show title text on breadcrumb

---
 frappe/hooks.py                              |  2 +-
 frappe/public/js/frappe/views/breadcrumbs.js | 17 +++++------------
 frappe/public/scss/desk/breadcrumb.scss      |  1 -
 frappe/public/scss/desk/page.scss            |  7 -------
 4 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/frappe/hooks.py b/frappe/hooks.py
index d7495427e7..46986a4b1e 100644
--- a/frappe/hooks.py
+++ b/frappe/hooks.py
@@ -38,9 +38,9 @@ app_include_css = [
 	"report.bundle.css",
 ]
 app_include_icons = [
+	"/assets/frappe/icons/icons.svg",
 	"/assets/frappe/icons/timeless/icons.svg",
 	"/assets/frappe/icons/espresso/icons.svg",
-	"/assets/frappe/icons/icons.svg",
 ]
 
 doctype_js = {
diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js
index 549d04d3f6..f7be249b79 100644
--- a/frappe/public/js/frappe/views/breadcrumbs.js
+++ b/frappe/public/js/frappe/views/breadcrumbs.js
@@ -81,18 +81,12 @@ frappe.breadcrumbs = {
 		this.append_breadcrumb_element(breadcrumbs.route, breadcrumbs.label);
 	},
 
-	append_breadcrumb_element(route, label, is_new_doc = false) {
+	append_breadcrumb_element(route, label, css_classes) {
 		const el = document.createElement("li");
 		const a = document.createElement("a");
 		a.href = route;
-		if (is_new_doc) {
-			const small_tag = document.createElement("small");
-			small_tag.classList.add("text-muted");
-			small_tag.innerText = label;
-			a.appendChild(small_tag);
-		} else {
-			a.innerText = label;
-		}
+		a.classList.add(css_classes);
+		a.innerText = label;
 		el.appendChild(a);
 		this.$breadcrumbs.append(el);
 	},
@@ -193,7 +187,7 @@ frappe.breadcrumbs = {
 			} else {
 				route = doctype_route;
 			}
-			this.append_breadcrumb_element(`/desk/${route}`, __(doctype));
+			this.append_breadcrumb_element(`/desk/${route}`, __(doctype), "title-text");
 		}
 	},
 
@@ -206,11 +200,10 @@ frappe.breadcrumbs = {
 		let docname_title;
 		if (docname.startsWith("new-" + doctype.toLowerCase().replace(/ /g, "-"))) {
 			docname_title = __("New {0}", [__(doctype)]);
-			this.append_breadcrumb_element(form_route, docname_title, true);
 		} else {
 			docname_title = doc.name;
-			this.append_breadcrumb_element(form_route, docname_title);
 		}
+		this.append_breadcrumb_element(form_route, docname_title);
 
 		if (view === "form") {
 			let last_crumb = this.$breadcrumbs.find("li").last();
diff --git a/frappe/public/scss/desk/breadcrumb.scss b/frappe/public/scss/desk/breadcrumb.scss
index 813d6f8c7b..a029a31254 100644
--- a/frappe/public/scss/desk/breadcrumb.scss
+++ b/frappe/public/scss/desk/breadcrumb.scss
@@ -6,7 +6,6 @@
 /*! This comment will be included even in compressed mode. */
 .navbar-breadcrumbs {
 	a {
-		font-size: var(--text-lg);
 		text-decoration: none;
 		color: var(--ink-gray-5);
 		font-weight: var(--weight-medium);
diff --git a/frappe/public/scss/desk/page.scss b/frappe/public/scss/desk/page.scss
index e96eb04306..c16ae1e82f 100644
--- a/frappe/public/scss/desk/page.scss
+++ b/frappe/public/scss/desk/page.scss
@@ -35,13 +35,6 @@
 	.title-area {
 		display: inline-flex;
 		align-items: center;
-		.title-text {
-			@include get_textstyle("xl", "semibold");
-			cursor: pointer;
-			margin-bottom: 0px;
-			margin-right: var(--margin-sm);
-			max-width: 25vw;
-		}
 		.indicator-pill {
 			margin-top: 2px;
 			margin-left: var(--margin-sm);

From f04cc0450254f65cee4d47b5ddf7612bea8bef55 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 17:25:40 +0530
Subject: [PATCH 08/14] test: apply doctype filter while seearching file

---
 cypress/integration/control_attach.js        | 14 +++++++++++++-
 frappe/public/js/frappe/views/breadcrumbs.js |  6 ++++--
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/cypress/integration/control_attach.js b/cypress/integration/control_attach.js
index 7a079edc6d..726a1ef036 100644
--- a/cypress/integration/control_attach.js
+++ b/cypress/integration/control_attach.js
@@ -224,7 +224,7 @@ context("Attach Control with Failed Document Save", () => {
 			.should("have.attr", "href")
 			.and("equal", "https://wallpaperplay.com/walls/full/8/2/b/72402.jpg");
 
-		cy.get(".title-text").then(($value) => {
+		cy.get(".title-text-form").then(($value) => {
 			docname = $value.text();
 		});
 	});
@@ -238,6 +238,18 @@ context("Attach Control with Failed Document Save", () => {
 			.blur()
 			.wait(500);
 		cy.get('input[data-fieldname="attached_to_name"]').click().type(docname).blur();
+		cy.findByRole("button", { name: "+ Add a Filter" }).click();
+		cy.get(".fieldname-select-area .form-control")
+			.last()
+			.click()
+			.type("Attached To Doctype{enter}")
+			.blur()
+			.wait(500);
+		cy.get('input[data-fieldname="attached_to_doctype"]')
+			.last()
+			.click()
+			.type("Test Mandatory Attach Control")
+			.blur();
 		cy.get(".filter-popover .apply-filters").click({ force: true });
 		cy.get("header .level-right .list-count").should("contain.text", "1 of 1");
 	});
diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js
index f7be249b79..a2002e585b 100644
--- a/frappe/public/js/frappe/views/breadcrumbs.js
+++ b/frappe/public/js/frappe/views/breadcrumbs.js
@@ -85,7 +85,9 @@ frappe.breadcrumbs = {
 		const el = document.createElement("li");
 		const a = document.createElement("a");
 		a.href = route;
-		a.classList.add(css_classes);
+		if (css_classes) {
+			a.classList.add(css_classes);
+		}
 		a.innerText = label;
 		el.appendChild(a);
 		this.$breadcrumbs.append(el);
@@ -203,7 +205,7 @@ frappe.breadcrumbs = {
 		} else {
 			docname_title = doc.name;
 		}
-		this.append_breadcrumb_element(form_route, docname_title);
+		this.append_breadcrumb_element(form_route, docname_title, "title-text-form");
 
 		if (view === "form") {
 			let last_crumb = this.$breadcrumbs.find("li").last();

From 1f33616371d1167a77b0b446fad4769bca1bf23d Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 17:37:38 +0530
Subject: [PATCH 09/14] test: fix route to worksapce test case

---
 cypress/integration/view_routing.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cypress/integration/view_routing.js b/cypress/integration/view_routing.js
index 5bb3c2d8db..794c2d6358 100644
--- a/cypress/integration/view_routing.js
+++ b/cypress/integration/view_routing.js
@@ -226,6 +226,6 @@ context("View", () => {
 
 	it("Route to Website Workspace", () => {
 		cy.visit("/desk/website");
-		cy.get(".title-text").should("contain", "Website");
+		cy.get(".workspace-title").should("contain", "Website");
 	});
 });

From da936cc2fe73b74c92c77ac70042c66e88b1e5c1 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 17:40:54 +0530
Subject: [PATCH 10/14] test: add correct id for copying title

---
 cypress/integration/control_data.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cypress/integration/control_data.js b/cypress/integration/control_data.js
index b4f737a8c9..aff4c18b32 100644
--- a/cypress/integration/control_data.js
+++ b/cypress/integration/control_data.js
@@ -53,7 +53,7 @@ context("Data Control", () => {
 			"contains",
 			"/desk/test-data-control/new-test-data-control"
 		);
-		cy.get(".title-text").should("have.text", "New Test Data Control");
+		cy.get(".title-text-form").should("have.text", "New Test Data Control");
 		cy.get('.frappe-control[data-fieldname="name1"]')
 			.find("label")
 			.should("have.class", "reqd");

From f2c37576af4fb39dbfa5c55f8c295a14a7fbf353 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Tue, 9 Dec 2025 23:10:16 +0530
Subject: [PATCH 11/14] test: fix kanban test cases

---
 cypress/integration/awesome_bar.js        |  2 +-
 cypress/integration/kanban.js             | 22 ++++++++++++++++++++++
 frappe/public/js/frappe/list/base_list.js |  2 +-
 frappe/public/js/frappe/ui/page.html      |  2 +-
 4 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/cypress/integration/awesome_bar.js b/cypress/integration/awesome_bar.js
index 2b562eed49..67c09517e1 100644
--- a/cypress/integration/awesome_bar.js
+++ b/cypress/integration/awesome_bar.js
@@ -78,7 +78,7 @@ context("Awesome Bar", () => {
 		cy.get("@awesome_bar").type("new web page");
 		cy.wait(150); // Wait a bit before hitting enter
 		cy.get("@awesome_bar").type("{enter}");
-		cy.get(".title-text:visible").should("have.text", "New Web Page");
+		cy.get(".title-text-form:visible").should("have.text", "New Web Page");
 	});
 
 	it("calculates math expressions", () => {
diff --git a/cypress/integration/kanban.js b/cypress/integration/kanban.js
index f4834450e2..5bba4adae7 100644
--- a/cypress/integration/kanban.js
+++ b/cypress/integration/kanban.js
@@ -4,6 +4,28 @@ context("Kanban Board", () => {
 		cy.visit("/desk");
 	});
 
+	it("Delete ToDo Kanban from list view if it exists", () => {
+		cy.go_to_list("Kanban Board");
+
+		cy.get(".list-row-container").should("exist");
+
+		cy.get(".list-row-container").then(($list_row) => {
+			cy.contains(".list-row-container", "ToDo Kanban").then(($row) => {
+				if (!$row.length) {
+					cy.log("ToDo Kanban does not exist — skipping delete.");
+					return;
+				}
+
+				cy.wrap($row).find(".list-row-checkbox").check({ force: true });
+
+				cy.get(".actions-btn-group > .btn").contains("Actions").click();
+				cy.get('.actions-btn-group > .dropdown-menu [data-label="Delete"]').click();
+
+				cy.click_modal_primary_button("Yes");
+			});
+		});
+	});
+
 	it("Create ToDo Kanban", () => {
 		cy.visit("/desk/todo");
 
diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js
index 4e6f4b2296..943b70f0a9 100644
--- a/frappe/public/js/frappe/list/base_list.js
+++ b/frappe/public/js/frappe/list/base_list.js
@@ -176,9 +176,9 @@ frappe.views.BaseList = class BaseList {
 	}
 
 	setup_page_head() {
+		this.set_breadcrumbs();
 		this.set_title();
 		this.set_menu_items();
-		this.set_breadcrumbs();
 	}
 
 	set_title() {
diff --git a/frappe/public/js/frappe/ui/page.html b/frappe/public/js/frappe/ui/page.html
index 12e63a576b..389345594b 100644
--- a/frappe/public/js/frappe/ui/page.html
+++ b/frappe/public/js/frappe/ui/page.html
@@ -1,7 +1,7 @@
 <div class="page-head flex {% if frappe.boot.read_only || frappe.boot.user.impersonated_by %}show-navbar{% endif %}">
 	<div class="container">
 		<div class="row flex-nowrap align-center page-head-content justify-between">
-			<div class="col-md-6 col-sm-6 col-xs-7 page-title">
+			<div class="col-md-5 col-sm-6 col-xs-7 page-title">
 				<div class="flex fill-width title-area">
 					{% if (!frappe.is_mobile()) { %}
 						<ul class="nav d-sm-flex navbar-breadcrumbs"></ul>

From 11146bb1cce9556e03b1e324f4f9cad9c59ef578 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Wed, 10 Dec 2025 10:38:48 +0530
Subject: [PATCH 12/14] chore: skip maxscale in github actions mariadb setup

---
 .github/actions/setup/action.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml
index 916f6378b4..6122a0e5df 100644
--- a/.github/actions/setup/action.yml
+++ b/.github/actions/setup/action.yml
@@ -100,7 +100,7 @@ runs:
     run: |
       # Install System Dependencies
       start_time=$(date +%s)
-      curl -LsS https://r.mariadb.com/downloads/mariadb_repo_setup | sudo bash -s -- --mariadb-server-version="mariadb-11.8.5"
+      curl -LsS https://r.mariadb.com/downloads/mariadb_repo_setup | sudo bash -s -- --mariadb-server-version="mariadb-11.8.5" --skip-maxscale
 
       sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
       wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -

From 1678d82a69399f8bcc24aa352ccdf5f1fbadadf5 Mon Sep 17 00:00:00 2001
From: Ejaaz Khan <ejaaz@frappe.io>
Date: Wed, 10 Dec 2025 11:01:09 +0530
Subject: [PATCH 13/14] test: remove optional delete anban test case

---
 cypress/integration/kanban.js | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/cypress/integration/kanban.js b/cypress/integration/kanban.js
index 5bba4adae7..f4834450e2 100644
--- a/cypress/integration/kanban.js
+++ b/cypress/integration/kanban.js
@@ -4,28 +4,6 @@ context("Kanban Board", () => {
 		cy.visit("/desk");
 	});
 
-	it("Delete ToDo Kanban from list view if it exists", () => {
-		cy.go_to_list("Kanban Board");
-
-		cy.get(".list-row-container").should("exist");
-
-		cy.get(".list-row-container").then(($list_row) => {
-			cy.contains(".list-row-container", "ToDo Kanban").then(($row) => {
-				if (!$row.length) {
-					cy.log("ToDo Kanban does not exist — skipping delete.");
-					return;
-				}
-
-				cy.wrap($row).find(".list-row-checkbox").check({ force: true });
-
-				cy.get(".actions-btn-group > .btn").contains("Actions").click();
-				cy.get('.actions-btn-group > .dropdown-menu [data-label="Delete"]').click();
-
-				cy.click_modal_primary_button("Yes");
-			});
-		});
-	});
-
 	it("Create ToDo Kanban", () => {
 		cy.visit("/desk/todo");
 

From c9e8a293a479530f0c09f63331de784ccc165afe Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Wed, 10 Dec 2025 11:30:13 +0530
Subject: [PATCH 14/14] fix: validate import columns only if type is insert

---
 frappe/core/doctype/data_import/importer.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/frappe/core/doctype/data_import/importer.py b/frappe/core/doctype/data_import/importer.py
index 2df0cf3df5..67507ef169 100644
--- a/frappe/core/doctype/data_import/importer.py
+++ b/frappe/core/doctype/data_import/importer.py
@@ -647,7 +647,8 @@ class ImportFile:
 		elif extension == "xls":
 			data = read_xls_file_from_attached_file(content)
 
-		self.validate_columns_of_import_file(data)
+		if self.import_type == INSERT:
+			self.validate_columns_of_import_file(data)
 		return data